Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Unified Diff: tools/telemetry/telemetry/unittest_util/page_set_smoke_test.py

Issue 921283002: [Telemetry] Add comment to page_set_smoke_test. Noop change (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Make the comment a little bit clearer. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/unittest_util/page_set_smoke_test.py
diff --git a/tools/telemetry/telemetry/unittest_util/page_set_smoke_test.py b/tools/telemetry/telemetry/unittest_util/page_set_smoke_test.py
index bf63d94370516d4de4f59909fe9d365b39a14725..7d89b98b138570ae3b51797084345e36043efd51 100644
--- a/tools/telemetry/telemetry/unittest_util/page_set_smoke_test.py
+++ b/tools/telemetry/telemetry/unittest_util/page_set_smoke_test.py
@@ -103,6 +103,8 @@ class PageSetSmokeTest(unittest.TestCase):
def CheckAttributesOfPageBasicAttributes(self, page):
self.assertTrue(not hasattr(page, 'disabled'))
self.assertTrue(
+ # We use basestring instead of str because page's url can be string of
+ # unicode.
isinstance(page.url, basestring),
msg='page %s \'s url must have type string' % page.display_name)
self.assertTrue(
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698