mojo/public/interfaces/bindings/tests/data/validation/conformance_msghdr_invalid_request_flags2.data - Issue 921223002: Cpp bindings: Return false from Validator::Accept() on unrecognized message or invalid flags

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/interfaces/bindings/tests/data/validation/conformance_msghdr_invalid_request_flags2.data

Issue 921223002: Cpp bindings: Return false from Validator::Accept() on unrecognized message or invalid flags (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Fix comments in JS test. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« mojo/public/cpp/bindings/tests/validation_unittest.cc ('K') | « mojo/public/interfaces/bindings/tests/data/validation/conformance_msghdr_invalid_request_flags1.expected ('k') | mojo/public/interfaces/bindings/tests/data/validation/conformance_msghdr_invalid_request_flags2.expected » ('j') | mojo/public/js/validation_unittests.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/interfaces/bindings/tests/data/validation/conformance_msghdr_invalid_request_flags2.data

diff --git a/mojo/public/interfaces/bindings/tests/data/validation/conformance_msghdr_invalid_request_flags2.data b/mojo/public/interfaces/bindings/tests/data/validation/conformance_msghdr_invalid_request_flags2.data

new file mode 100644

index 0000000000000000000000000000000000000000..a5067c36d41f85ccab70835224ce1ca2e84512f1

--- /dev/null

+++ b/mojo/public/interfaces/bindings/tests/data/validation/conformance_msghdr_invalid_request_flags2.data

@@ -0,0 +1,6 @@

+[dist4]message_header // num_bytes

+[u4]3 // version

+[u4]12 // name

yzshen1 2015/03/13 22:55:03 nit: please align the comment with other lines.

rudominer 2015/03/16 21:24:32 Done.

+[u4]0 // flags: kMessageExpectsResponse is not set but expected.

yzshen1 2015/03/13 22:55:03 Does it make sense to name this test conformance_m

yzshen1 2015/03/13 22:55:03 80 chars?

rudominer 2015/03/16 21:24:31 Done.

+[u8]1 // request_id

+[anchr]message_header