mojo/public/interfaces/bindings/tests/data/validation/conformance_msghdr_invalid_request_flags2.data - Issue 921223002: Cpp bindings: Return false from Validator::Accept() on unrecognized message or invalid flags

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: mojo/public/interfaces/bindings/tests/data/validation/conformance_msghdr_invalid_request_flags2.data

Issue 921223002: Cpp bindings: Return false from Validator::Accept() on unrecognized message or invalid flags (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Fix comments in JS test. Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« mojo/public/cpp/bindings/tests/validation_unittest.cc ('K') | « mojo/public/interfaces/bindings/tests/data/validation/conformance_msghdr_invalid_request_flags1.expected ('k') | mojo/public/interfaces/bindings/tests/data/validation/conformance_msghdr_invalid_request_flags2.expected » ('j') | mojo/public/js/validation_unittests.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 [dist4]message_header // num_bytes

	2 [u4]3 // version

	3 [u4]12 // name
	yzshen1 2015/03/13 22:55:03 nit: please align the comment with other lines. nit: please align the comment with other lines. rudominer 2015/03/16 21:24:32 Done. Show quoted text On 2015/03/13 22:55:03, yzshen1 (OOO Mar 2 - 22) wrote: > nit: please align the comment with other lines. Done.
	4 [u4]0 // flags: kMessageExpectsResponse is not set but expected .
	yzshen1 2015/03/13 22:55:03 Does it make sense to name this test conformance_m Does it make sense to name this test conformance_mthd12_xxx? Because it is not something that the message header validator can detect by itself. Instead, knowledge about the actual interface running is required to detect the error. Similarly, conformance_msghdr_invalid_request_flags1 may be renamed as conformance_mthd0_xxx. (etc.) What do you think? yzshen1 2015/03/13 22:55:03 80 chars? 80 chars? rudominer 2015/03/16 21:24:31 Done. Show quoted text On 2015/03/13 22:55:03, yzshen1 (OOO Mar 2 - 22) wrote: > 80 chars? Done.
	5 [u8]1 // request_id

	6 [anchr]message_header

OLD	NEW