Chromium Code Reviews| Index: mojo/public/js/validation_unittests.js |
| diff --git a/mojo/public/js/validation_unittests.js b/mojo/public/js/validation_unittests.js |
| index a04879cd4b00f3bda1d466b88837bcdcae35371d..cc6c477a8a2aefed8dded77d8fd83565e65d74f5 100644 |
| --- a/mojo/public/js/validation_unittests.js |
| +++ b/mojo/public/js/validation_unittests.js |
| @@ -225,11 +225,17 @@ define([ |
| expect(testFiles.length).toBeGreaterThan(0); |
| for (var i = 0; i < testFiles.length; i++) { |
| - // TODO(hansmuller, yzshen): Temporarily skipping: |
| - // - array pointer overflow tests; |
| - // - struct versioning tests (tests with "mthd11" in the name). |
| + // TODO(hansmuller) Temporarily skipping array pointer overflow tests |
| + // because JS numbers are limited to 53 bits. |
| + // TODO(yzshen) Skipping struct versioning tests (tests with "mthd11" |
| + // in the name) because ... |
|
yzshen1
2015/03/13 22:55:03
... -> the feature is not supported in JS yet.
rudominer
2015/03/16 21:24:32
Done.
|
| + // TODO(rudominer): Temporarily skipping 'no-such-method', and |
| + // 'invalid_request_flags'until additional logic in |
| + // *RequestValidator and *ResponseValidator is ported from cpp to js. |
| if (testFiles[i].indexOf("overflow") != -1 || |
| - testFiles[i].indexOf("mthd11") != -1) { |
| + testFiles[i].indexOf("mthd11") != -1 || |
| + testFiles[i].indexOf("no_such_method") != -1 || |
| + testFiles[i].indexOf("invalid_request_flags") != -1) { |
| console.log("[Skipping " + testFiles[i] + "]"); |
| continue; |
| } |
| @@ -257,12 +263,6 @@ define([ |
| expect(testFiles.length).toBeGreaterThan(0); |
| for (var i = 0; i < testFiles.length; i++) { |
| - // TODO(hansmuller): Temporarily skipping array pointer overflow tests. |
| - if (testFiles[i].indexOf("overflow") != -1) { |
| - console.log("[Skipping " + testFiles[i] + "]"); |
| - continue; |
| - } |
| - |
| var testMessage = readTestMessage(testFiles[i]); |
| var handles = new Array(testMessage.handleCount); |
| var testMessagePipe = new core.createMessagePipe(); |