components/autofill/core/common/password_form.h - Issue 920683002: [Password Generation] Add negative votes for crowdsourcing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/common/password_form.h

Issue 920683002: [Password Generation] Add negative votes for crowdsourcing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Cleanup Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/password_manager/native_backend_kwallet_x_unittest.cc ('K') | « components/autofill/core/browser/field_types.h ('k') | components/autofill/core/common/password_form.cc » ('j') | components/password_manager/core/browser/password_form_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/common/password_form.h

diff --git a/components/autofill/core/common/password_form.h b/components/autofill/core/common/password_form.h

index 29d369a7f5a7f08f3522669fec40c76ee5e54724..224a304f6680fa107562b64c434c514529ebe4a0 100644

--- a/components/autofill/core/common/password_form.h

+++ b/components/autofill/core/common/password_form.h

@@ -205,6 +205,17 @@ struct PasswordForm {

// When parsing an HTML form, this is normally set.

FormData form_data;

+ enum GenerationUploadStatus {

vabr (Chromium) 2015/02/12 10:08:25 I explicitly acknowledge the choice of enum over "

vabr (Chromium) 2015/02/12 10:08:25 Declaration order: types should be before member v

Garrett Casto 2015/02/12 22:15:35 Yeah, didn't explicitly mention this, but there do

Garrett Casto 2015/02/12 22:15:35 Done.

+ NO_SIGNAL_SENT,

+ POSITIVE_SIGNAL_SENT,

+ NEGATIVE_SIGNAL_SENT,

+ // Reserve a few values for future use.

+ UNKNOWN_STATUS = 10

+ };

+ // What information has been sent to the Autofill server about this form.

+ GenerationUploadStatus generation_upload_status;

// These following fields are set by a website using the Credential Manager

// API. They will be empty and remain unused for sites which do not use that

// API.