components/autofill/core/common/password_form.cc - Issue 920683002: [Password Generation] Add negative votes for crowdsourcing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/common/password_form.cc

Issue 920683002: [Password Generation] Add negative votes for crowdsourcing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Cleanup Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/autofill/core/common/password_form.h ('K') | « components/autofill/core/common/password_form.h ('k') | components/password_manager/core/browser/login_database.cc » ('j') | components/password_manager/core/browser/password_form_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/common/password_form.cc

diff --git a/components/autofill/core/common/password_form.cc b/components/autofill/core/common/password_form.cc

index 2b627669d2fd11d38d032d95d3f4e97cb56157cf..3ff8447a069f2dc5ad457b86b2b08a51e14333f7 100644

--- a/components/autofill/core/common/password_form.cc

+++ b/components/autofill/core/common/password_form.cc

@@ -20,6 +20,7 @@ PasswordForm::PasswordForm()

blacklisted_by_user(false),

type(TYPE_MANUAL),

times_used(0),

+ generation_upload_status(NO_SIGNAL_SENT),

skip_zero_click(false) {

}

@@ -52,6 +53,7 @@ bool PasswordForm::operator==(const PasswordForm& form) const {

type == form.type &&

times_used == form.times_used &&

form_data.SameFormAs(form.form_data) &&

+ generation_upload_status == form.generation_upload_status &&

display_name == form.display_name &&

avatar_url == form.avatar_url &&

federation_url == form.federation_url &&

@@ -88,6 +90,7 @@ std::ostream& operator<<(std::ostream& os, const PasswordForm& form) {

<< " type: " << form.type

<< " times_used: " << form.times_used

<< " form_data: " << form.form_data

+ << " generation_upload_status: " << form.generation_upload_status

<< " display_name: " << base::UTF16ToUTF8(form.display_name)

<< " avatar_url: " << form.avatar_url

<< " federation_url: " << form.federation_url