[Password Generation] Add negative votes for crowdsourcing

components/autofill/core/common/password_form.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_AUTOFILL_CORE_COMMON_PASSWORD_FORM_H__
 #define COMPONENTS_AUTOFILL_CORE_COMMON_PASSWORD_FORM_H__
 
 #include <map>
 #include <string>
 #include <vector>
@@ skipping 187 matching lines @@
   // When parsing an HTML form, this is not used.
   int times_used;
 
   // Autofill representation of this form. Used to communicate with the
   // Autofill servers if necessary. Currently this is only used to help
   // determine forms where we can trigger password generation.
   //
   // When parsing an HTML form, this is normally set.
   FormData form_data;
 
+  enum GenerationUploadStatus {

[vabr (Chromium), 2015/02/12 10:08:25]

I explicitly acknowledge the choice of enum over "enum class" here, because of
implicit conversion to int being handy for serialisation.

[vabr (Chromium), 2015/02/12 10:08:25]

Declaration order: types should be before member variables.
http://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Declaration_O...

[Garrett Casto, 2015/02/12 22:15:35]

Yeah, didn't explicitly mention this, but there doesn't seem to be better to use
enum class here.

[Garrett Casto, 2015/02/12 22:15:35]

Done.

+    NO_SIGNAL_SENT,
+    POSITIVE_SIGNAL_SENT,
+    NEGATIVE_SIGNAL_SENT,
+    // Reserve a few values for future use.
+    UNKNOWN_STATUS = 10
+  };
+
+  // What information has been sent to the Autofill server about this form.
+  GenerationUploadStatus generation_upload_status;
+
   // These following fields are set by a website using the Credential Manager
   // API. They will be empty and remain unused for sites which do not use that
   // API.
   //
   // User friendly name to show in the UI.
   base::string16 display_name;
 
   // The URL of the user's avatar to display in the UI.
   GURL avatar_url;
 
@@ skipping 21 matching lines @@
 
 typedef std::map<base::string16, const PasswordForm*> ConstPasswordFormMap;
 
 // For testing.
 std::ostream& operator<<(std::ostream& os,
                          const autofill::PasswordForm& form);
 
 }  // namespace autofill
 
 #endif  // COMPONENTS_AUTOFILL_CORE_COMMON_PASSWORD_FORM_H__