Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2664)

Unified Diff: chrome/browser/password_manager/native_backend_libsecret_unittest.cc

Issue 920683002: [Password Generation] Add negative votes for crowdsourcing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Cleanup Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/native_backend_libsecret_unittest.cc
diff --git a/chrome/browser/password_manager/native_backend_libsecret_unittest.cc b/chrome/browser/password_manager/native_backend_libsecret_unittest.cc
index 2e531ceb76b8c165b1475a7b4e3964872816a18a..7e78de7fa3ff812ca2596f80ff99aaefff136e7f 100644
--- a/chrome/browser/password_manager/native_backend_libsecret_unittest.cc
+++ b/chrome/browser/password_manager/native_backend_libsecret_unittest.cc
@@ -246,6 +246,8 @@ void CheckPasswordChanges(const PasswordStoreChangeList& expected_list,
EXPECT_EQ(expected.avatar_url, actual.avatar_url);
EXPECT_EQ(expected.federation_url, actual.federation_url);
EXPECT_EQ(expected.skip_zero_click, actual.skip_zero_click);
+ EXPECT_EQ(expected.generation_upload_status,
+ actual.generation_upload_status);
}
}
@@ -289,6 +291,7 @@ class NativeBackendLibsecretTest : public testing::Test {
form_google_.avatar_url = GURL("http://www.google.com/avatar");
form_google_.federation_url = GURL("http://www.google.com/federation_url");
form_google_.skip_zero_click = true;
+ form_google_.generation_upload_status = PasswordForm::POSITIVE_SIGNAL_SENT;
form_facebook_.origin = GURL("http://www.facebook.com/");
form_facebook_.action = GURL("http://www.facebook.com/login");
@@ -304,6 +307,7 @@ class NativeBackendLibsecretTest : public testing::Test {
form_facebook_.avatar_url = GURL("http://www.facebook.com/avatar");
form_facebook_.federation_url = GURL("http://www.facebook.com/federation");
form_facebook_.skip_zero_click = true;
+ form_facebook_.generation_upload_status = PasswordForm::NO_SIGNAL_SENT;
form_isc_.origin = GURL("http://www.isc.org/");
form_isc_.action = GURL("http://www.isc.org/auth");
@@ -362,7 +366,7 @@ class NativeBackendLibsecretTest : public testing::Test {
const PasswordForm& form,
const std::string& app_string) {
EXPECT_EQ(UTF16ToUTF8(form.password_value), item->value->password);
- EXPECT_EQ(20u, g_hash_table_size(item->attributes));
+ EXPECT_EQ(21u, g_hash_table_size(item->attributes));
CheckStringAttribute(item, "origin_url", form.origin.spec());
CheckStringAttribute(item, "action_url", form.action.spec());
CheckStringAttribute(item, "username_element",
@@ -388,6 +392,8 @@ class NativeBackendLibsecretTest : public testing::Test {
CheckStringAttribute(item, "avatar_url", form.avatar_url.spec());
CheckStringAttribute(item, "federation_url", form.federation_url.spec());
CheckUint32Attribute(item, "skip_zero_click", form.skip_zero_click);
+ CheckUint32Attribute(item, "generation_upload_status",
+ form.generation_upload_status);
CheckStringAttribute(item, "application", app_string);
}

Powered by Google App Engine
This is Rietveld 408576698