Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Unified Diff: chrome/browser/password_manager/native_backend_libsecret.cc

Issue 920683002: [Password Generation] Add negative votes for crowdsourcing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Cleanup Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/native_backend_libsecret.cc
diff --git a/chrome/browser/password_manager/native_backend_libsecret.cc b/chrome/browser/password_manager/native_backend_libsecret.cc
index d23ac4512d3f69b61d61869b237cd5619c4c8da2..43673a3532b6f968a288df3228d4b56ad4fbd435 100644
--- a/chrome/browser/password_manager/native_backend_libsecret.cc
+++ b/chrome/browser/password_manager/native_backend_libsecret.cc
@@ -120,6 +120,7 @@ const SecretSchema kLibsecretSchema = {
{"avatar_url", SECRET_SCHEMA_ATTRIBUTE_STRING},
{"federation_url", SECRET_SCHEMA_ATTRIBUTE_STRING},
{"skip_zero_click", SECRET_SCHEMA_ATTRIBUTE_INTEGER},
+ {"generation_upload_status", SECRET_SCHEMA_ATTRIBUTE_INTEGER},
// This field is always "chrome-profile_id" so that we can search for it.
{"application", SECRET_SCHEMA_ATTRIBUTE_STRING},
{nullptr, SECRET_SCHEMA_ATTRIBUTE_STRING}}};
@@ -190,6 +191,9 @@ scoped_ptr<PasswordForm> FormOutOfAttributes(GHashTable* attrs) {
form->avatar_url = GURL(GetStringFromAttributes(attrs, "avatar_url"));
form->federation_url = GURL(GetStringFromAttributes(attrs, "federation_url"));
form->skip_zero_click = GetUintFromAttributes(attrs, "skip_zero_click");
+ form->generation_upload_status =
+ static_cast<PasswordForm::GenerationUploadStatus>(
+ GetUintFromAttributes(attrs, "generation_upload_status"));
return form.Pass();
}
@@ -439,6 +443,7 @@ bool NativeBackendLibsecret::RawAddLogin(const PasswordForm& form) {
"avatar_url", form.avatar_url.spec().c_str(),
"federation_url", form.federation_url.spec().c_str(),
"skip_zero_click", form.skip_zero_click,
+ "generation_upload_status", form.generation_upload_status,
"application", app_string_.c_str(), nullptr);
if (error) {

Powered by Google App Engine
This is Rietveld 408576698