Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Unified Diff: tools/telemetry/telemetry/results/page_test_results.py

Issue 920523002: [Telemetry] Reduce memory usage in presence of TraceValues (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase -_- Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/results/page_test_results.py
diff --git a/tools/telemetry/telemetry/results/page_test_results.py b/tools/telemetry/telemetry/results/page_test_results.py
index ff5e519a38860ff5a72a251919c8e65418694509..819684f4dde2a550e8760a390e3e217abb8810e7 100644
--- a/tools/telemetry/telemetry/results/page_test_results.py
+++ b/tools/telemetry/telemetry/results/page_test_results.py
@@ -134,6 +134,20 @@ class PageTestResults(object):
def _GetStringFromExcInfo(self, err):
return ''.join(traceback.format_exception(*err))
+ def CleanUp(self):
+ """Clean up any TraceValues contained within this results object."""
+ for run in self._all_page_runs:
+ for v in run.values:
+ if isinstance(v, trace.TraceValue):
+ v.CleanUp()
+ run.values.remove(v)
+
+ def __enter__(self):
+ return self
+
+ def __exit__(self, _, __, ___):
+ self.CleanUp()
+
def WillRunPage(self, page):
assert not self._current_page_run, 'Did not call DidRunPage.'
self._current_page_run = page_run.PageRun(page)
« no previous file with comments | « tools/telemetry/telemetry/benchmark.py ('k') | tools/telemetry/telemetry/results/page_test_results_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698