Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Unified Diff: tools/telemetry/telemetry/benchmark.py

Issue 920523002: [Telemetry] Reduce memory usage in presence of TraceValues (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase -_- Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/telemetry/telemetry/results/page_test_results.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/benchmark.py
diff --git a/tools/telemetry/telemetry/benchmark.py b/tools/telemetry/telemetry/benchmark.py
index 5723294fee38f020c1d7c398ce45488f285e52d4..6a34ec204c51cc0ec0fc132a6167b96749b65e7f 100644
--- a/tools/telemetry/telemetry/benchmark.py
+++ b/tools/telemetry/telemetry/benchmark.py
@@ -189,22 +189,22 @@ class Benchmark(command_line.Command):
self._DownloadGeneratedProfileArchive(finder_options)
benchmark_metadata = self.GetMetadata()
- results = results_options.CreateResults(
- benchmark_metadata, finder_options, self.ValueCanBeAddedPredicate)
- try:
- user_story_runner.Run(pt, us, expectations, finder_options, results,
- max_failures=self._max_failures)
- return_code = min(254, len(results.failures))
- except Exception:
- exception_formatter.PrintFormattedException()
- return_code = 255
-
- bucket = cloud_storage.BUCKET_ALIASES[finder_options.upload_bucket]
- if finder_options.upload_results:
- results.UploadTraceFilesToCloud(bucket)
- results.UploadProfilingFilesToCloud(bucket)
-
- results.PrintSummary()
+ with results_options.CreateResults(benchmark_metadata,
+ finder_options) as results:
+ try:
+ user_story_runner.Run(pt, us, expectations, finder_options, results,
+ max_failures=self._max_failures)
+ return_code = min(254, len(results.failures))
+ except Exception:
+ exception_formatter.PrintFormattedException()
+ return_code = 255
+
+ bucket = cloud_storage.BUCKET_ALIASES[finder_options.upload_bucket]
+ if finder_options.upload_results:
+ results.UploadTraceFilesToCloud(bucket)
+ results.UploadProfilingFilesToCloud(bucket)
+
+ results.PrintSummary()
return return_code
def _DownloadGeneratedProfileArchive(self, options):
« no previous file with comments | « no previous file | tools/telemetry/telemetry/results/page_test_results.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698