Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Unified Diff: tools/telemetry/telemetry/results/page_test_results_unittest.py

Issue 920523002: [Telemetry] Reduce memory usage in presence of TraceValues (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase -_- Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/telemetry/telemetry/results/page_test_results.py ('k') | tools/telemetry/telemetry/value/trace.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/results/page_test_results_unittest.py
diff --git a/tools/telemetry/telemetry/results/page_test_results_unittest.py b/tools/telemetry/telemetry/results/page_test_results_unittest.py
index b8313dad6a01c9995aea423c90f46e52fc9719cd..21006a15d6fb51693cc98940eb62ce400c487e43 100644
--- a/tools/telemetry/telemetry/results/page_test_results_unittest.py
+++ b/tools/telemetry/telemetry/results/page_test_results_unittest.py
@@ -15,7 +15,6 @@ from telemetry.value import scalar
from telemetry.value import skip
from telemetry.value import trace
-
class PageTestResultsTest(base_test_results_unittest.BaseTestResultsUnittest):
def setUp(self):
ps = page_set.PageSet(file_path=os.path.dirname(__file__))
@@ -234,3 +233,36 @@ class PageTestResultsTest(base_test_results_unittest.BaseTestResultsUnittest):
values = results.FindAllTraceValues()
self.assertEquals(2, len(values))
+
+ def testCleanUpCleansUpTraceValues(self):
+ results = page_test_results.PageTestResults()
+ v0 = trace.TraceValue(None, trace_data.TraceData({'test': 1}))
+ v1 = trace.TraceValue(None, trace_data.TraceData({'test': 2}))
+
+ results.WillRunPage(self.pages[0])
+ results.AddValue(v0)
+ results.DidRunPage(self.pages[0])
+
+ results.WillRunPage(self.pages[1])
+ results.AddValue(v1)
+ results.DidRunPage(self.pages[1])
+
+ results.CleanUp()
+ self.assertTrue(v0.cleaned_up)
+ self.assertTrue(v1.cleaned_up)
+
+ def testNoTracesLeftAfterCleanUp(self):
+ results = page_test_results.PageTestResults()
+ v0 = trace.TraceValue(None, trace_data.TraceData({'test': 1}))
+ v1 = trace.TraceValue(None, trace_data.TraceData({'test': 2}))
+
+ results.WillRunPage(self.pages[0])
+ results.AddValue(v0)
+ results.DidRunPage(self.pages[0])
+
+ results.WillRunPage(self.pages[1])
+ results.AddValue(v1)
+ results.DidRunPage(self.pages[1])
+
+ results.CleanUp()
+ self.assertFalse(results.FindAllTraceValues())
« no previous file with comments | « tools/telemetry/telemetry/results/page_test_results.py ('k') | tools/telemetry/telemetry/value/trace.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698