Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 920333003: Revert of Use uint16s for texture coordinates when rendering text. (Closed)

Created:
5 years, 10 months ago by reed2
Modified:
5 years, 10 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Use uint16s for texture coordinates when rendering text. (patchset #5 id:80001 of https://codereview.chromium.org/917373002/) Reason for revert: speculative revert for DEPS failures https://codereview.chromium.org/932973002/ Original issue's description: > Use uint16s for texture coordinates when rendering text. > > Allows us to push more vertices into a given vertex buffer, with > a slight performance improvement. > > Committed: https://skia.googlesource.com/skia/+/059034d252007d0dd86fff5ffdbb53cbcb10d34b TBR=joshualitt@google.com,robertphillips@google.com,bsalomon@google.com,reed@google.com,djsollen@google.com,jvanverth@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/e4ef1ca5be11aed67c0ed0c7eb1862696fb063e3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+181 lines, -245 lines) Patch
M gyp/gpu.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M include/gpu/GrTypesPriv.h View 6 chunks +5 lines, -11 lines 0 comments Download
M src/gpu/GrAADistanceFieldPathRenderer.cpp View 2 chunks +20 lines, -22 lines 0 comments Download
M src/gpu/GrBitmapTextContext.cpp View 4 chunks +35 lines, -58 lines 0 comments Download
M src/gpu/GrDistanceFieldTextContext.cpp View 2 chunks +28 lines, -51 lines 0 comments Download
D src/gpu/GrFontAtlasSizes.h View 1 chunk +0 lines, -28 lines 0 comments Download
M src/gpu/GrFontCache.cpp View 4 chunks +15 lines, -7 lines 0 comments Download
M src/gpu/effects/GrBitmapTextGeoProc.cpp View 3 chunks +2 lines, -6 lines 0 comments Download
M src/gpu/effects/GrDistanceFieldTextureEffect.cpp View 23 chunks +76 lines, -59 lines 0 comments Download
M src/gpu/gl/GrGLVertexArray.h View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
reed2
Created Revert of Use uint16s for texture coordinates when rendering text.
5 years, 10 months ago (2015-02-18 02:38:20 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/920333003/1
5 years, 10 months ago (2015-02-18 02:38:30 UTC) #2
commit-bot: I haz the power
5 years, 10 months ago (2015-02-18 02:38:43 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/e4ef1ca5be11aed67c0ed0c7eb1862696fb063e3

Powered by Google App Engine
This is Rietveld 408576698