Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 918973002: Removed one bogus CompilationInfo constructor. (Closed)

Created:
5 years, 10 months ago by Sven Panne
Modified:
5 years, 10 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Removed one bogus CompilationInfo constructor. Use a fake code stub instead, basically following the null object pattern. Committed: https://crrev.com/222001ace4daec968de22dcfc1bfa343bf386e5d Cr-Commit-Position: refs/heads/master@{#26610}

Patch Set 1 #

Patch Set 2 : Removed debugging PrintF. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -26 lines) Patch
M src/code-stubs.h View 1 chunk +24 lines, -0 lines 0 comments Download
M src/compiler.h View 2 chunks +1 line, -2 lines 0 comments Download
M src/compiler.cc View 1 chunk +0 lines, -15 lines 0 comments Download
M src/compiler/pipeline.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-instruction.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M test/cctest/compiler/test-linkage.cc View 2 chunks +8 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Sven Panne
5 years, 10 months ago (2015-02-12 12:32:23 UTC) #2
Michael Starzinger
LGTM.
5 years, 10 months ago (2015-02-12 12:42:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/918973002/20001
5 years, 10 months ago (2015-02-12 12:55:50 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-12 12:57:13 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-12 12:57:28 UTC) #7
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/222001ace4daec968de22dcfc1bfa343bf386e5d
Cr-Commit-Position: refs/heads/master@{#26610}

Powered by Google App Engine
This is Rietveld 408576698