Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Unified Diff: src/code-stubs.h

Issue 918973002: Removed one bogus CompilationInfo constructor. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Removed debugging PrintF. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/compiler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/code-stubs.h
diff --git a/src/code-stubs.h b/src/code-stubs.h
index fb2fbe55df5398d9ed4d7c0351b5a888e9b8d0c3..dd1d34bdfb3d227073f1bf780bb312d5026a8d88 100644
--- a/src/code-stubs.h
+++ b/src/code-stubs.h
@@ -294,6 +294,30 @@ class CodeStub BASE_EMBEDDED {
};
+// TODO(svenpanne) This class is only used to construct a more or less sensible
+// CompilationInfo for testing purposes, basically pretending that we are
+// currently compiling some kind of code stub. Remove this when the pipeline and
+// testing machinery is restructured in such a way that we don't have to come up
+// with a CompilationInfo out of thin air, although we only need a few parts of
+// it.
+struct FakeStubForTesting : public CodeStub {
+ explicit FakeStubForTesting(Isolate* isolate) : CodeStub(isolate) {}
+
+ // Only used by pipeline.cc's GetDebugName in DEBUG mode.
+ Major MajorKey() const OVERRIDE { return CodeStub::NoCache; }
+
+ CallInterfaceDescriptor GetCallInterfaceDescriptor() OVERRIDE {
+ UNREACHABLE();
+ return CallInterfaceDescriptor();
+ }
+
+ Handle<Code> GenerateCode() OVERRIDE {
+ UNREACHABLE();
+ return Handle<Code>();
+ }
+};
+
+
#define DEFINE_CODE_STUB_BASE(NAME, SUPER) \
public: \
NAME(uint32_t key, Isolate* isolate) : SUPER(key, isolate) {} \
« no previous file with comments | « no previous file | src/compiler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698