Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Unified Diff: test/cctest/compiler/test-linkage.cc

Issue 918973002: Removed one bogus CompilationInfo constructor. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Removed debugging PrintF. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/cctest/compiler/test-instruction.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/compiler/test-linkage.cc
diff --git a/test/cctest/compiler/test-linkage.cc b/test/cctest/compiler/test-linkage.cc
index e832b3da3688fd3f15d58614fd46db9cb870742a..13695b2e0b44861fed1b26e201653958f3bb50d2 100644
--- a/test/cctest/compiler/test-linkage.cc
+++ b/test/cctest/compiler/test-linkage.cc
@@ -4,6 +4,7 @@
#include "src/v8.h"
+#include "src/code-stubs.h"
#include "src/compiler.h"
#include "src/zone.h"
@@ -73,11 +74,14 @@ TEST(TestLinkageJSFunctionIncoming) {
TEST(TestLinkageCodeStubIncoming) {
Isolate* isolate = CcTest::InitIsolateOnce();
- CompilationInfoWithZone info(static_cast<CodeStub*>(NULL), isolate);
+ ToNumberStub stub(isolate);
+ CompilationInfoWithZone info(&stub, isolate);
CallDescriptor* descriptor = Linkage::ComputeIncoming(info.zone(), &info);
- // TODO(titzer): test linkage creation with a bonafide code stub.
- // this just checks current behavior.
- CHECK(!descriptor);
+ CHECK(descriptor);
+ CHECK_EQ(1, static_cast<int>(descriptor->JSParameterCount()));
+ CHECK_EQ(1, static_cast<int>(descriptor->ReturnCount()));
+ CHECK_EQ(Operator::kNoProperties, descriptor->properties());
+ CHECK_EQ(false, descriptor->IsJSFunctionCall());
}
« no previous file with comments | « test/cctest/compiler/test-instruction.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698