Move responsibility for definition of ExtraICState bits into the ICs.

Move responsibility for definition of ExtraICState bits into the ICs.

Currently it's in the Code object for some ICs and in ICs for other ICs.
This should make it easier to alter bits as needed.

2) Recover an extra bit in the code object to give us 6 bits for the extra ic state. We'll need it soon to store contextual state.

3) Cleanup code that treated StrictMode enum and ExtraICState enum as interchangeble.

R=verwaest@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=18136

[mvstanton, 2013-11-27 16:08:08]

Hi Toon, PTAL,
--Michael

[mvstanton, 2013-11-27 21:34:37]

Hi Toon, here are my updates in response to your comments.

Moving Code::kNoExtraICState to IC::kNoExtraICState is the right thing to do but
circular dependencies prompted me to keep a definition in Code as well because
Code is defined before ICs and CodeStubs don't see ICs either.

I'm tempted to just declare 0 as meaning no extra ic state and get rid of the
constant, now that things are clearer in other ways.
Thanks for having a look. Looking forward to the next step with Contextual!!
--Michael

[Toon Verwaest, 2013-11-28 09:58:47]

I wouldn't move kNoExtraICState to IC unless you can remove it fully from Code.
As we discussed, either keep it in Code or move it out as a global.

https://codereview.chromium.org/91803003/diff/20001/src/ic.h
File src/ic.h (left):

https://codereview.chromium.org/91803003/diff/20001/src/ic.h#oldcode568
src/ic.h:568: virtual StrictModeFlag strict_mode() const { return strict_mode_;
}
I guess you can make this nonvirtual now, and remove the other copies?

https://codereview.chromium.org/91803003/diff/20001/src/stub-cache.cc
File src/stub-cache.cc (right):

https://codereview.chromium.org/91803003/diff/20001/src/stub-cache.cc#newcode454
src/stub-cache.cc:454: ? CONTEXTUAL : NOT_CONTEXTUAL);
nit: indent by 4 extra spaces

[mvstanton, 2013-11-28 11:23:10]

Hi Toon,
Okay, comments addressed. The big change though here is moving ExtraICState to a
standalone definition outside of the Code class. This solves some thorny
dependency issues. It's a big renaming but I support it on the grounds that
ownership of the field is more firmly in the IC camp this way.

https://codereview.chromium.org/91803003/diff/20001/src/ic.h
File src/ic.h (left):

https://codereview.chromium.org/91803003/diff/20001/src/ic.h#oldcode568
src/ic.h:568: virtual StrictModeFlag strict_mode() const { return strict_mode_;
}
On 2013/11/28 09:58:47, Toon Verwaest wrote:
> I guess you can make this nonvirtual now, and remove the other copies?

Done, and that caused a ripple into the stub compiler, where a method that was
passed strict_mode now accepts ExtraICState, then decoding that state only when
it knows it has a STORE_IC and needs to inquire about strict mode.

https://codereview.chromium.org/91803003/diff/20001/src/stub-cache.cc
File src/stub-cache.cc (right):

https://codereview.chromium.org/91803003/diff/20001/src/stub-cache.cc#newcode454
src/stub-cache.cc:454: ? CONTEXTUAL : NOT_CONTEXTUAL);
On 2013/11/28 09:58:47, Toon Verwaest wrote:
> nit: indent by 4 extra spaces

Fixed in both places.

[Toon Verwaest, 2013-11-28 15:15:04]

lgtm

[mvstanton, 2013-11-28 15:33:08]

Committed patchset #6 manually as r18136 (presubmit successful).