Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Side by Side Diff: src/arm/stub-cache-arm.cc

Issue 91803003: Move responsibility for definition of ExtraICState bits into the ICs. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: A couple more nits. Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/ic-arm.cc ('k') | src/builtins.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 728 matching lines...) Expand 10 before | Expand all | Expand 10 after
739 __ bind(label); 739 __ bind(label);
740 __ mov(this->name(), Operand(name)); 740 __ mov(this->name(), Operand(name));
741 } 741 }
742 } 742 }
743 743
744 744
745 static void GenerateCallFunction(MacroAssembler* masm, 745 static void GenerateCallFunction(MacroAssembler* masm,
746 Handle<Object> object, 746 Handle<Object> object,
747 const ParameterCount& arguments, 747 const ParameterCount& arguments,
748 Label* miss, 748 Label* miss,
749 Code::ExtraICState extra_ic_state) { 749 ExtraICState extra_ic_state) {
750 // ----------- S t a t e ------------- 750 // ----------- S t a t e -------------
751 // -- r0: receiver 751 // -- r0: receiver
752 // -- r1: function to call 752 // -- r1: function to call
753 // ----------------------------------- 753 // -----------------------------------
754 754
755 // Check that the function really is a function. 755 // Check that the function really is a function.
756 __ JumpIfSmi(r1, miss); 756 __ JumpIfSmi(r1, miss);
757 __ CompareObjectType(r1, r3, r3, JS_FUNCTION_TYPE); 757 __ CompareObjectType(r1, r3, r3, JS_FUNCTION_TYPE);
758 __ b(ne, miss); 758 __ b(ne, miss);
759 759
(...skipping 191 matching lines...) Expand 10 before | Expand all | Expand 10 after
951 951
952 GenerateFastApiDirectCall(masm, optimization, argc, true); 952 GenerateFastApiDirectCall(masm, optimization, argc, true);
953 } 953 }
954 954
955 955
956 class CallInterceptorCompiler BASE_EMBEDDED { 956 class CallInterceptorCompiler BASE_EMBEDDED {
957 public: 957 public:
958 CallInterceptorCompiler(StubCompiler* stub_compiler, 958 CallInterceptorCompiler(StubCompiler* stub_compiler,
959 const ParameterCount& arguments, 959 const ParameterCount& arguments,
960 Register name, 960 Register name,
961 Code::ExtraICState extra_ic_state) 961 ExtraICState extra_ic_state)
962 : stub_compiler_(stub_compiler), 962 : stub_compiler_(stub_compiler),
963 arguments_(arguments), 963 arguments_(arguments),
964 name_(name), 964 name_(name),
965 extra_ic_state_(extra_ic_state) {} 965 extra_ic_state_(extra_ic_state) {}
966 966
967 void Compile(MacroAssembler* masm, 967 void Compile(MacroAssembler* masm,
968 Handle<JSObject> object, 968 Handle<JSObject> object,
969 Handle<JSObject> holder, 969 Handle<JSObject> holder,
970 Handle<Name> name, 970 Handle<Name> name,
971 LookupResult* lookup, 971 LookupResult* lookup,
(...skipping 163 matching lines...) Expand 10 before | Expand all | Expand 10 after
1135 } 1135 }
1136 // If interceptor returns no-result sentinel, call the constant function. 1136 // If interceptor returns no-result sentinel, call the constant function.
1137 __ LoadRoot(scratch, Heap::kNoInterceptorResultSentinelRootIndex); 1137 __ LoadRoot(scratch, Heap::kNoInterceptorResultSentinelRootIndex);
1138 __ cmp(r0, scratch); 1138 __ cmp(r0, scratch);
1139 __ b(ne, interceptor_succeeded); 1139 __ b(ne, interceptor_succeeded);
1140 } 1140 }
1141 1141
1142 StubCompiler* stub_compiler_; 1142 StubCompiler* stub_compiler_;
1143 const ParameterCount& arguments_; 1143 const ParameterCount& arguments_;
1144 Register name_; 1144 Register name_;
1145 Code::ExtraICState extra_ic_state_; 1145 ExtraICState extra_ic_state_;
1146 }; 1146 };
1147 1147
1148 1148
1149 void StubCompiler::GenerateTailCall(MacroAssembler* masm, Handle<Code> code) { 1149 void StubCompiler::GenerateTailCall(MacroAssembler* masm, Handle<Code> code) {
1150 __ Jump(code, RelocInfo::CODE_TARGET); 1150 __ Jump(code, RelocInfo::CODE_TARGET);
1151 } 1151 }
1152 1152
1153 1153
1154 #undef __ 1154 #undef __
1155 #define __ ACCESS_MASM(masm()) 1155 #define __ ACCESS_MASM(masm())
(...skipping 2011 matching lines...) Expand 10 before | Expand all | Expand 10 after
3167 // ----------------------------------- 3167 // -----------------------------------
3168 TailCallBuiltin(masm, Builtins::kKeyedLoadIC_Miss); 3168 TailCallBuiltin(masm, Builtins::kKeyedLoadIC_Miss);
3169 } 3169 }
3170 3170
3171 3171
3172 #undef __ 3172 #undef __
3173 3173
3174 } } // namespace v8::internal 3174 } } // namespace v8::internal
3175 3175
3176 #endif // V8_TARGET_ARCH_ARM 3176 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « src/arm/ic-arm.cc ('k') | src/builtins.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698