Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/ia32/stub-cache-ia32.cc

Issue 91803003: Move responsibility for definition of ExtraICState bits into the ICs. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: A couple more nits. Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ia32/ic-ia32.cc ('k') | src/ic.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 630 matching lines...) Expand 10 before | Expand all | Expand 10 after
641 restore_context ? 641 restore_context ?
642 &context_restore_operand : NULL); 642 &context_restore_operand : NULL);
643 } 643 }
644 644
645 645
646 class CallInterceptorCompiler BASE_EMBEDDED { 646 class CallInterceptorCompiler BASE_EMBEDDED {
647 public: 647 public:
648 CallInterceptorCompiler(StubCompiler* stub_compiler, 648 CallInterceptorCompiler(StubCompiler* stub_compiler,
649 const ParameterCount& arguments, 649 const ParameterCount& arguments,
650 Register name, 650 Register name,
651 Code::ExtraICState extra_state) 651 ExtraICState extra_state)
652 : stub_compiler_(stub_compiler), 652 : stub_compiler_(stub_compiler),
653 arguments_(arguments), 653 arguments_(arguments),
654 name_(name), 654 name_(name),
655 extra_state_(extra_state) {} 655 extra_state_(extra_state) {}
656 656
657 void Compile(MacroAssembler* masm, 657 void Compile(MacroAssembler* masm,
658 Handle<JSObject> object, 658 Handle<JSObject> object,
659 Handle<JSObject> holder, 659 Handle<JSObject> holder,
660 Handle<Name> name, 660 Handle<Name> name,
661 LookupResult* lookup, 661 LookupResult* lookup,
(...skipping 164 matching lines...) Expand 10 before | Expand all | Expand 10 after
826 // Leave the internal frame. 826 // Leave the internal frame.
827 } 827 }
828 828
829 __ cmp(eax, masm->isolate()->factory()->no_interceptor_result_sentinel()); 829 __ cmp(eax, masm->isolate()->factory()->no_interceptor_result_sentinel());
830 __ j(not_equal, interceptor_succeeded); 830 __ j(not_equal, interceptor_succeeded);
831 } 831 }
832 832
833 StubCompiler* stub_compiler_; 833 StubCompiler* stub_compiler_;
834 const ParameterCount& arguments_; 834 const ParameterCount& arguments_;
835 Register name_; 835 Register name_;
836 Code::ExtraICState extra_state_; 836 ExtraICState extra_state_;
837 }; 837 };
838 838
839 839
840 void StoreStubCompiler::GenerateRestoreName(MacroAssembler* masm, 840 void StoreStubCompiler::GenerateRestoreName(MacroAssembler* masm,
841 Label* label, 841 Label* label,
842 Handle<Name> name) { 842 Handle<Name> name) {
843 if (!label->is_unused()) { 843 if (!label->is_unused()) {
844 __ bind(label); 844 __ bind(label);
845 __ mov(this->name(), Immediate(name)); 845 __ mov(this->name(), Immediate(name));
846 } 846 }
(...skipping 2453 matching lines...) Expand 10 before | Expand all | Expand 10 after
3300 // ----------------------------------- 3300 // -----------------------------------
3301 TailCallBuiltin(masm, Builtins::kKeyedLoadIC_Miss); 3301 TailCallBuiltin(masm, Builtins::kKeyedLoadIC_Miss);
3302 } 3302 }
3303 3303
3304 3304
3305 #undef __ 3305 #undef __
3306 3306
3307 } } // namespace v8::internal 3307 } } // namespace v8::internal
3308 3308
3309 #endif // V8_TARGET_ARCH_IA32 3309 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/ia32/ic-ia32.cc ('k') | src/ic.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698