cc: Move occlusion debug rects into the debug layer borders.

cc: Move occlusion debug rects into the debug layer borders.

Previously we had 2 command line flags to show opaque and non-opaque
rects. These were only available by command line and AFAIK are not ever
used.

Once upon a time, in a ui compositor far far away, the layer border
color encoded if the layer was marked as contents_opaque(). This was a
useful feature for chrome developers. When the border drawing code was
removed from the ui compositor and consolidated into cc, this feature
was destroyed since cc had many more layer colors to support.

The opaque/non-opaque rect drawing is a lot of lines of code and hacked
into weird places, that get in the way of removing the occlusion
tracker from the draw loop. So, just remove it, and instead have the
layer borders show opaqueness again. We do so by having a translucent
larger layer inside the normal layer for opaque windows. (For the
DelegatedRendererLayerImpl, since it's a special rainbow window, it
does a fill over its contents of awesomeness.)

R=ajuma, enne, vmpstr
BUG=446751
Committed: https://crrev.com/069ac12bec702497d2fdad632397ac652eecc2d1
Cr-Commit-Position: refs/heads/master@{#315896}

[danakj, 2015-02-11 22:07:52]

+piman for content and ui review

[danakj, 2015-02-11 22:08:13]

danakj@chromium.org changed reviewers:
+ piman@chromium.org

[danakj, 2015-02-11 22:08:14]

On 2015/02/11 22:07:52, danakj wrote:
> +piman for content and ui review

[vmpstr, 2015-02-11 22:22:22]

I didn't see this anywhere, but can you confirm that we don't push these rects
into trace viewer via AsValue calls?

Also I sometimes browse the web with debug colors on <_< does that mean that I
will see more fun colors?

https://codereview.chromium.org/917763003/diff/1/cc/layers/delegated_renderer...
File cc/layers/delegated_renderer_layer_impl.cc (right):

https://codereview.chromium.org/917763003/diff/1/cc/layers/delegated_renderer...
cc/layers/delegated_renderer_layer_impl.cc:370:
static_cast<uint8_t>(SkColorGetA(colors[i % kNumColors]) * 0.1f));
nit: make 0.1 a kConstant above? maybe?

https://codereview.chromium.org/917763003/diff/1/cc/layers/delegated_renderer...
cc/layers/delegated_renderer_layer_impl.cc:371: gfx::Rect fill_rect(x, 0, width,
content_bounds().height());
Can you put a comment saying that blah blah vertical stripes of translucent
color? I guess kinda like above, but it took me a while to see where the shape
was defined for some reason :(

https://codereview.chromium.org/917763003/diff/1/cc/layers/layer_impl.cc
File cc/layers/layer_impl.cc (right):

https://codereview.chromium.org/917763003/diff/1/cc/layers/layer_impl.cc#newc...
cc/layers/layer_impl.cc:331: // The inner fill is more transparent then the
border.
nit: than

Can you also elaborate on the shape of the fill in the comment?

[danakj, 2015-02-11 22:33:40]

On Wed, Feb 11, 2015 at 2:22 PM, <vmpstr@chromium.org> wrote:

> I didn't see this anywhere, but can you confirm that we don't push these
> rects
> into trace viewer via AsValue calls?
>
> Also I sometimes browse the web with debug colors on <_< does that mean
> that I
> will see more fun colors?
>

If a layer in the renderer is opaque you will get a border indicating it.
If your webpage uses a nested WebView with a DelegatedRendererLayerImpl you
could get rainbows :) Generally I think you'll only see them with
--ui-show-layer-borders.


>
>
> https://codereview.chromium.org/917763003/diff/1/cc/
> layers/delegated_renderer_layer_impl.cc
> File cc/layers/delegated_renderer_layer_impl.cc (right):
>
> https://codereview.chromium.org/917763003/diff/1/cc/
> layers/delegated_renderer_layer_impl.cc#newcode370
> cc/layers/delegated_renderer_layer_impl.cc:370:
> static_cast<uint8_t>(SkColorGetA(colors[i % kNumColors]) * 0.1f));
> nit: make 0.1 a kConstant above? maybe?
>
> https://codereview.chromium.org/917763003/diff/1/cc/
> layers/delegated_renderer_layer_impl.cc#newcode371
> cc/layers/delegated_renderer_layer_impl.cc:371: gfx::Rect fill_rect(x,
> 0, width, content_bounds().height());
> Can you put a comment saying that blah blah vertical stripes of
> translucent color? I guess kinda like above, but it took me a while to
> see where the shape was defined for some reason :(
>
> https://codereview.chromium.org/917763003/diff/1/cc/layers/layer_impl.cc
> File cc/layers/layer_impl.cc (right):
>
> https://codereview.chromium.org/917763003/diff/1/cc/layers/layer_impl.cc#
> newcode331
> cc/layers/layer_impl.cc:331: // The inner fill is more transparent then
> the border.
> nit: than
>
> Can you also elaborate on the shape of the fill in the comment?
>
> https://codereview.chromium.org/917763003/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[piman, 2015-02-11 23:06:42]

lgtm

[danakj, 2015-02-11 23:43:56]

New patchsets have been uploaded after l-g-t-m from piman@chromium.org

[danakj, 2015-02-11 23:44:01]

https://codereview.chromium.org/917763003/diff/1/cc/layers/delegated_renderer...
File cc/layers/delegated_renderer_layer_impl.cc (right):

https://codereview.chromium.org/917763003/diff/1/cc/layers/delegated_renderer...
cc/layers/delegated_renderer_layer_impl.cc:370:
static_cast<uint8_t>(SkColorGetA(colors[i % kNumColors]) * 0.1f));
On 2015/02/11 22:22:22, vmpstr wrote:
> nit: make 0.1 a kConstant above? maybe?

Done.

https://codereview.chromium.org/917763003/diff/1/cc/layers/delegated_renderer...
cc/layers/delegated_renderer_layer_impl.cc:371: gfx::Rect fill_rect(x, 0, width,
content_bounds().height());
On 2015/02/11 22:22:22, vmpstr wrote:
> Can you put a comment saying that blah blah vertical stripes of translucent
> color? I guess kinda like above, but it took me a while to see where the shape
> was defined for some reason :(

Done.

https://codereview.chromium.org/917763003/diff/1/cc/layers/layer_impl.cc
File cc/layers/layer_impl.cc (right):

https://codereview.chromium.org/917763003/diff/1/cc/layers/layer_impl.cc#newc...
cc/layers/layer_impl.cc:331: // The inner fill is more transparent then the
border.
On 2015/02/11 22:22:22, vmpstr wrote:
> nit: than
> 
> Can you also elaborate on the shape of the fill in the comment?

Done.

[danakj, 2015-02-11 23:44:07]

PTAL

[vmpstr, 2015-02-11 23:58:52]

lgtm

[danakj, 2015-02-12 00:05:20]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2015-02-12 00:06:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/917763003/20001

[commit-bot: I haz the power, 2015-02-12 00:59:30]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-02-12 01:00:25]

Patchset 2 (id:??) landed as
https://crrev.com/069ac12bec702497d2fdad632397ac652eecc2d1
Cr-Commit-Position: refs/heads/master@{#315896}