Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 916153003: Add namespace sandbox to about page. (Closed)

Created:
5 years, 10 months ago by rickyz (no longer on Chrome)
Modified:
5 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add namespace sandbox to about page. This unindents the lines about PID/network namespaces, since those now apply to both the setuid or unprivileged namespace sandbox. This is a resubmit of https://codereview.chromium.org/873283004/ TBR=jhawkins@chromium.org BUG=312380 Committed: https://crrev.com/e1274d29f116c9eba6bc3d16d2b5d53a77b99a9a Cr-Commit-Position: refs/heads/master@{#315945}

Patch Set 1 : Initial change (from issue 873283004) #

Patch Set 2 : Update test for about page changes. #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -31 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +7 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/about_ui.cc View 1 2 2 chunks +12 lines, -19 lines 0 comments Download
M chrome/test/data/webui/sandboxstatus_browsertest.js View 1 1 chunk +24 lines, -8 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
rickyz (no longer on Chrome)
Here's a resend of the sandbox about page change. I plan to submit this after ...
5 years, 10 months ago (2015-02-12 02:09:03 UTC) #3
jln (very slow on Chromium)
lgtm Add in the commit message that this is a re-send of https://.... and you ...
5 years, 10 months ago (2015-02-12 03:11:32 UTC) #4
jln (very slow on Chromium)
Did you figure out on which bots chrome/test/data/webui/sandboxstatus_browsertest.js run these days? I didn't look yet, ...
5 years, 10 months ago (2015-02-12 03:11:59 UTC) #5
rickyz (no longer on Chrome)
On 2015/02/12 03:11:59, jln wrote: > Did you figure out on which bots > chrome/test/data/webui/sandboxstatus_browsertest.js ...
5 years, 10 months ago (2015-02-12 04:05:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/916153003/60001
5 years, 10 months ago (2015-02-12 08:17:52 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:60001)
5 years, 10 months ago (2015-02-12 08:31:05 UTC) #11
commit-bot: I haz the power
5 years, 10 months ago (2015-02-12 08:31:52 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/e1274d29f116c9eba6bc3d16d2b5d53a77b99a9a
Cr-Commit-Position: refs/heads/master@{#315945}

Powered by Google App Engine
This is Rietveld 408576698