Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 873283004: Add namespace sandbox to about page. (Closed)

Created:
5 years, 10 months ago by rickyz (no longer on Chrome)
Modified:
5 years, 10 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, jln+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add namespace sandbox to about page. This unindents the lines about PID/network namespaces, since those now apply to both the setuid or unprivileged namespace sandbox. BUG=312380 Committed: https://crrev.com/1ef7ee1ee899087d8632a4f905a3a11697a20b81 Cr-Commit-Position: refs/heads/master@{#315116}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Update comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -27 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +7 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/about_ui.cc View 1 2 chunks +12 lines, -19 lines 0 comments Download
M content/common/sandbox_linux/sandbox_linux.cc View 3 chunks +8 lines, -2 lines 0 comments Download
M content/public/common/sandbox_linux.h View 2 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
rickyz (no longer on Chrome)
Maybe a little premature, but this doesn't strictly depend on anything in the other changes, ...
5 years, 10 months ago (2015-02-04 09:29:57 UTC) #2
jln (very slow on Chromium)
lgtm https://chromiumcodereview.appspot.com/873283004/diff/1/chrome/browser/ui/webui/about_ui.cc File chrome/browser/ui/webui/about_ui.cc (right): https://chromiumcodereview.appspot.com/873283004/diff/1/chrome/browser/ui/webui/about_ui.cc#newcode891 chrome/browser/ui/webui/about_ui.cc:891: // The setuid sandbox is required as our ...
5 years, 10 months ago (2015-02-04 23:16:23 UTC) #3
rickyz (no longer on Chrome)
Thanks, adding: jhawkins@ for chrome/browser/ui/webui/about_ui.cc nasko@ for content/public/common/sandbox_linux.h https://chromiumcodereview.appspot.com/873283004/diff/1/chrome/browser/ui/webui/about_ui.cc File chrome/browser/ui/webui/about_ui.cc (right): https://chromiumcodereview.appspot.com/873283004/diff/1/chrome/browser/ui/webui/about_ui.cc#newcode891 chrome/browser/ui/webui/about_ui.cc:891: // ...
5 years, 10 months ago (2015-02-04 23:30:21 UTC) #6
nasko
Rubberstamp LGTM
5 years, 10 months ago (2015-02-05 00:31:00 UTC) #7
James Hawkins
lgtm
5 years, 10 months ago (2015-02-06 15:33:08 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/873283004/20001
5 years, 10 months ago (2015-02-06 19:49:42 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-06 21:54:14 UTC) #11
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/1ef7ee1ee899087d8632a4f905a3a11697a20b81 Cr-Commit-Position: refs/heads/master@{#315116}
5 years, 10 months ago (2015-02-06 21:55:33 UTC) #12
magjed_chromium
5 years, 10 months ago (2015-02-10 12:01:30 UTC) #13
Message was sent while issue was closed.
A revert of this CL has been created in
https://codereview.chromium.org/872143006/ by rickyz@chromium.org.

The reason for reverting is: crbug/456993.

Powered by Google App Engine
This is Rietveld 408576698