ppapi/cpp/dev/ime_input_event_dev.cc - Issue 915403003: Enable size_t to int truncation warnings in PPAPI

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ppapi/cpp/dev/ime_input_event_dev.cc

Issue 915403003: Enable size_t to int truncation warnings in PPAPI (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ppapi/cpp/dev/ime_input_event_dev.cc

diff --git a/ppapi/cpp/dev/ime_input_event_dev.cc b/ppapi/cpp/dev/ime_input_event_dev.cc

index 9ddc16e913881cfe2f0247dfdb12552150ddac69..3396a3980a2d06c3c14e44330a2ce9fa18b143ae 100644

--- a/ppapi/cpp/dev/ime_input_event_dev.cc

+++ b/ppapi/cpp/dev/ime_input_event_dev.cc

@@ -61,7 +61,8 @@ IMEInputEvent_Dev::IMEInputEvent_Dev(

uint32_t dummy = 0;

PassRefFromConstructor(get_interface<PPB_IMEInputEvent_Dev_0_2>()->Create(

instance.pp_instance(), type, time_stamp, text.pp_var(),

- segment_offsets.empty() ? 0 : segment_offsets.size() - 1,

+ segment_offsets.empty() ? 0u :

+ static_cast<uint32_t>(segment_offsets.size() - 1),

segment_offsets.empty() ? &dummy : &segment_offsets[0],

target_segment, selection.first, selection.second));

}