ppapi/cpp/dev/file_chooser_dev.cc - Issue 915403003: Enable size_t to int truncation warnings in PPAPI

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ppapi/cpp/dev/file_chooser_dev.cc

Issue 915403003: Enable size_t to int truncation warnings in PPAPI (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ppapi/cpp/dev/file_chooser_dev.cc

diff --git a/ppapi/cpp/dev/file_chooser_dev.cc b/ppapi/cpp/dev/file_chooser_dev.cc

index b7124a1044ba7ec2dc9dfc4841ec01a0449f80a3..2efb346dbeeafb87f5205231f019b17141d545d7 100644

--- a/ppapi/cpp/dev/file_chooser_dev.cc

+++ b/ppapi/cpp/dev/file_chooser_dev.cc

@@ -82,7 +82,7 @@ void FileChooser_Dev::CallbackConverter(void* user_data, int32_t result) {

// number of items is 0.

void* output_buf = data->output.GetDataBuffer(

data->output.user_data,

- selected_files.size(), sizeof(PP_Resource));

+ static_cast<uint32_t>(selected_files.size()), sizeof(PP_Resource));

if (output_buf) {

if (!selected_files.empty()) {

memcpy(output_buf, &selected_files[0],