ppapi/cpp/dev/scriptable_object_deprecated.cc - Issue 915403003: Enable size_t to int truncation warnings in PPAPI

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ppapi/cpp/dev/scriptable_object_deprecated.cc

Issue 915403003: Enable size_t to int truncation warnings in PPAPI (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ppapi/cpp/dev/scriptable_object_deprecated.cc

diff --git a/ppapi/cpp/dev/scriptable_object_deprecated.cc b/ppapi/cpp/dev/scriptable_object_deprecated.cc

index 1b701cb6651c45c452103083854e0691d6b9904e..19c4738c007ff1877c30853288378eacab7ccbe1 100644

--- a/ppapi/cpp/dev/scriptable_object_deprecated.cc

+++ b/ppapi/cpp/dev/scriptable_object_deprecated.cc

@@ -73,8 +73,8 @@ void GetAllPropertyNames(void* object,

const PPB_Memory_Dev* memory_if = static_cast<const PPB_Memory_Dev*>(

pp::Module::Get()->GetBrowserInterface(PPB_MEMORY_DEV_INTERFACE));

- *properties = static_cast<PP_Var*>(

- memory_if->MemAlloc(sizeof(PP_Var) * props.size()));

+ *properties = static_cast<PP_Var*>(memory_if->MemAlloc(

+ static_cast<uint32_t>(sizeof(PP_Var) * props.size())));

for (size_t i = 0; i < props.size(); ++i)

(*properties)[i] = props[i].Detach();