Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(618)

Unified Diff: ppapi/BUILD.gn

Issue 915403003: Enable size_t to int truncation warnings in PPAPI (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ppapi/BUILD.gn
diff --git a/ppapi/BUILD.gn b/ppapi/BUILD.gn
index dd722c14acd170657f910708e4fe5592a6c7eed4..24827ab0d15acb063db506f2259a883d6ec4f46c 100644
--- a/ppapi/BUILD.gn
+++ b/ppapi/BUILD.gn
@@ -29,15 +29,6 @@ source_set("ppapi_macros") {
source_set("ppapi_cpp_objects") {
sources = gypi_values.cpp_source_files
-
- if (is_win) {
- cflags = [ "/we4244" ] # Implicit conversion, possible loss of data.
- } else {
- cflags = [
- "-Wextra",
- "-pedantic",
- ]
- }
}
source_set("ppapi_cpp") {
@@ -46,13 +37,6 @@ source_set("ppapi_cpp") {
"cpp/ppp_entrypoints.cc",
]
- if (is_posix) {
- cflags = [
- "-Wextra",
- "-pedantic",
- ]
- }
-
deps = [
":ppapi_c",
":ppapi_cpp_objects",
@@ -433,8 +417,6 @@ component("ppapi_shared") {
if (is_mac) {
libs = [ "QuartzCore.framework" ]
- } else if (is_win) {
- cflags = [ "/wd4267" ] # size_t to int truncation.
}
}
@@ -750,10 +732,6 @@ component("ppapi_proxy") {
"//ui/surface",
blink_target,
]
-
- if (is_win) {
- cflags = [ "/wd4267" ] # size_t to int truncation.
- }
}
component("ppapi_host") {

Powered by Google App Engine
This is Rietveld 408576698