Enable size_t to int truncation warnings in PPAPI

Enable size_t to int truncation warnings in PPAPI

Also removed a few extra "-Wpedantic" warnings in ppapi_cpp. I don't see a good justification why this should be different than the rest of the project.

Fix GN error in media.

NOPRESUBMIT=true

Committed: https://crrev.com/669d47b1bf59279718ab6ef07e9eb69fb42c8aa4
Cr-Commit-Position: refs/heads/master@{#316289}

[brettw, 2015-02-12 18:44:01]

brettw@chromium.org changed reviewers:
+ dmichael@chromium.org

[brettw, 2015-02-12 18:46:17]

The GN warnings on Windows weren't set up properly to disable these warning.
Rather than fixed that, I fixed the source of the warnings and removed the
overrides from the GYP build

[dmichael (off chromium), 2015-02-12 18:56:43]

Thanks for doing this! A few comments, but o/w lgtm

https://codereview.chromium.org/915403003/diff/20001/media/BUILD.gn
File media/BUILD.gn (right):

https://codereview.chromium.org/915403003/diff/20001/media/BUILD.gn#newcode640
media/BUILD.gn:640: # http://crbug.com/171009
This change probably belongs in a different CL?

https://codereview.chromium.org/915403003/diff/20001/ppapi/proxy/file_ref_res...
File ppapi/proxy/file_ref_resource.cc (right):

https://codereview.chromium.org/915403003/diff/20001/ppapi/proxy/file_ref_res...
ppapi/proxy/file_ref_resource.cc:32: int path_size =
static_cast<int>(create_info_.internal_path.size());
nit: may be a good idea to use checked_cast for type conversions that may
overflow (but admittedly it's super unlikely here)

https://codereview.chromium.org/915403003/diff/20001/ppapi/proxy/url_loader_r...
File ppapi/proxy/url_loader_resource.cc (right):

https://codereview.chromium.org/915403003/diff/20001/ppapi/proxy/url_loader_r...
ppapi/proxy/url_loader_resource.cc:396: return
static_cast<int32_t>(bytes_to_copy);
another unsigned->signed where checked_cast might be good.

[brettw, 2015-02-12 21:08:38]

New patchsets have been uploaded after l-g-t-m from dmichael@chromium.org

[brettw, 2015-02-12 21:09:34]

I chacnged to a bunch of checked_casts when it looked like the value might come
form the plugin. These are all theoretically OK either way since they should
still be in the plugin sandbox, but they're low frequency and it's better to be
safe.

I added a few more files that the trybots identified.

https://codereview.chromium.org/915403003/diff/20001/media/BUILD.gn
File media/BUILD.gn (right):

https://codereview.chromium.org/915403003/diff/20001/media/BUILD.gn#newcode640
media/BUILD.gn:640: # http://crbug.com/171009
On 2015/02/12 18:56:43, dmichael wrote:
> This change probably belongs in a different CL?

This change started as a GN build fix. This was the first part :) Anyway, this
is correct or GN doesn't run on x64.

[brettw, 2015-02-12 21:25:08]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2015-02-12 21:26:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/915403003/40001

[commit-bot: I haz the power, 2015-02-12 21:32:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-12 21:32:34]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[brettw, 2015-02-12 22:44:02]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2015-02-12 22:44:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/915403003/40001

[commit-bot: I haz the power, 2015-02-12 22:51:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-12 22:51:57]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[brettw, 2015-02-13 00:15:21]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2015-02-13 00:16:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/915403003/50001

[commit-bot: I haz the power, 2015-02-13 00:58:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-13 00:58:22]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_d...)

[brettw, 2015-02-13 01:01:40]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2015-02-13 01:02:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/915403003/50001

[commit-bot: I haz the power, 2015-02-13 01:45:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-13 01:45:07]

Try jobs failed on following builders:
  android_clang_dbg_recipe on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)

[brettw, 2015-02-13 19:25:47]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2015-02-13 19:26:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/915403003/70001

[brettw, 2015-02-13 20:10:32]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2015-02-13 20:11:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/915403003/90001

[commit-bot: I haz the power, 2015-02-13 21:17:46]

Committed patchset #6 (id:90001)

[commit-bot: I haz the power, 2015-02-13 21:18:17]

Patchset 6 (id:??) landed as
https://crrev.com/669d47b1bf59279718ab6ef07e9eb69fb42c8aa4
Cr-Commit-Position: refs/heads/master@{#316289}