Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(497)

Side by Side Diff: ppapi/tests/test_host_resolver_private.cc

Issue 915403003: Enable size_t to int truncation warnings in PPAPI (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: ppapi_unittests win x64 Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ppapi/tests/test_host_resolver.cc ('k') | ppapi/tests/test_memory.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ppapi/tests/test_host_resolver_private.h" 5 #include "ppapi/tests/test_host_resolver_private.h"
6 6
7 #include "ppapi/c/private/ppb_net_address_private.h" 7 #include "ppapi/c/private/ppb_net_address_private.h"
8 #include "ppapi/cpp/module_impl.h" 8 #include "ppapi/cpp/module_impl.h"
9 #include "ppapi/cpp/private/host_resolver_private.h" 9 #include "ppapi/cpp/private/host_resolver_private.h"
10 #include "ppapi/cpp/private/tcp_socket_private.h" 10 #include "ppapi/cpp/private/tcp_socket_private.h"
(...skipping 82 matching lines...) Expand 10 before | Expand all | Expand 10 after
93 *bytes_written = callback.result(); 93 *bytes_written = callback.result();
94 PASS(); 94 PASS();
95 } 95 }
96 96
97 std::string TestHostResolverPrivate::CheckHTTPResponse( 97 std::string TestHostResolverPrivate::CheckHTTPResponse(
98 pp::TCPSocketPrivate* socket, 98 pp::TCPSocketPrivate* socket,
99 const std::string& request, 99 const std::string& request,
100 const std::string& response) { 100 const std::string& response) {
101 int32_t rv = 0; 101 int32_t rv = 0;
102 ASSERT_SUBTEST_SUCCESS( 102 ASSERT_SUBTEST_SUCCESS(
103 SyncWrite(socket, request.c_str(), request.size(), &rv)); 103 SyncWrite(socket, request.c_str(), static_cast<int32_t>(request.size()),
104 &rv));
104 std::vector<char> response_buffer(response.size()); 105 std::vector<char> response_buffer(response.size());
105 ASSERT_SUBTEST_SUCCESS( 106 ASSERT_SUBTEST_SUCCESS(
106 SyncRead(socket, &response_buffer[0], response.size(), &rv)); 107 SyncRead(socket, &response_buffer[0],
108 static_cast<int32_t>(response.size()), &rv));
107 std::string actual_response(&response_buffer[0], rv); 109 std::string actual_response(&response_buffer[0], rv);
108 if (response != actual_response) { 110 if (response != actual_response) {
109 return "CheckHTTPResponse failed, expected: " + response + 111 return "CheckHTTPResponse failed, expected: " + response +
110 ", actual: " + actual_response; 112 ", actual: " + actual_response;
111 } 113 }
112 PASS(); 114 PASS();
113 } 115 }
114 116
115 std::string TestHostResolverPrivate::SyncResolve( 117 std::string TestHostResolverPrivate::SyncResolve(
116 pp::HostResolverPrivate* host_resolver, 118 pp::HostResolverPrivate* host_resolver,
(...skipping 20 matching lines...) Expand all
137 const PP_HostResolver_Private_Hint &hint) { 139 const PP_HostResolver_Private_Hint &hint) {
138 pp::HostResolverPrivate host_resolver(instance_); 140 pp::HostResolverPrivate host_resolver(instance_);
139 141
140 ASSERT_SUBTEST_SUCCESS(SyncResolve(&host_resolver, host_, port_, hint)); 142 ASSERT_SUBTEST_SUCCESS(SyncResolve(&host_resolver, host_, port_, hint));
141 143
142 const size_t size = host_resolver.GetSize(); 144 const size_t size = host_resolver.GetSize();
143 ASSERT_TRUE(size >= 1); 145 ASSERT_TRUE(size >= 1);
144 146
145 PP_NetAddress_Private address; 147 PP_NetAddress_Private address;
146 for (size_t i = 0; i < size; ++i) { 148 for (size_t i = 0; i < size; ++i) {
147 ASSERT_TRUE(host_resolver.GetNetAddress(i, &address)); 149 ASSERT_TRUE(host_resolver.GetNetAddress(
150 static_cast<uint32_t>(i), &address));
148 151
149 pp::TCPSocketPrivate socket(instance_); 152 pp::TCPSocketPrivate socket(instance_);
150 ASSERT_SUBTEST_SUCCESS(SyncConnect(&socket, address)); 153 ASSERT_SUBTEST_SUCCESS(SyncConnect(&socket, address));
151 ASSERT_SUBTEST_SUCCESS(CheckHTTPResponse(&socket, 154 ASSERT_SUBTEST_SUCCESS(CheckHTTPResponse(&socket,
152 "GET / HTTP/1.0\r\n\r\n", 155 "GET / HTTP/1.0\r\n\r\n",
153 "HTTP")); 156 "HTTP"));
154 socket.Disconnect(); 157 socket.Disconnect();
155 } 158 }
156 159
157 ASSERT_FALSE(host_resolver.GetNetAddress(size, &address)); 160 ASSERT_FALSE(host_resolver.GetNetAddress(
161 static_cast<uint32_t>(size), &address));
158 pp::Var canonical_name = host_resolver.GetCanonicalName(); 162 pp::Var canonical_name = host_resolver.GetCanonicalName();
159 ASSERT_TRUE(canonical_name.is_string()); 163 ASSERT_TRUE(canonical_name.is_string());
160 pp::TCPSocketPrivate socket(instance_); 164 pp::TCPSocketPrivate socket(instance_);
161 ASSERT_SUBTEST_SUCCESS(SyncConnect(&socket, 165 ASSERT_SUBTEST_SUCCESS(SyncConnect(&socket,
162 canonical_name.AsString(), 166 canonical_name.AsString(),
163 port_)); 167 port_));
164 ASSERT_SUBTEST_SUCCESS(CheckHTTPResponse(&socket, 168 ASSERT_SUBTEST_SUCCESS(CheckHTTPResponse(&socket,
165 "GET / HTTP/1.0\r\n\r\n", 169 "GET / HTTP/1.0\r\n\r\n",
166 "HTTP")); 170 "HTTP"));
167 socket.Disconnect(); 171 socket.Disconnect();
168 172
169 PASS(); 173 PASS();
170 } 174 }
171 175
172 std::string TestHostResolverPrivate::TestResolve() { 176 std::string TestHostResolverPrivate::TestResolve() {
173 PP_HostResolver_Private_Hint hint; 177 PP_HostResolver_Private_Hint hint;
174 hint.family = PP_NETADDRESSFAMILY_PRIVATE_UNSPECIFIED; 178 hint.family = PP_NETADDRESSFAMILY_PRIVATE_UNSPECIFIED;
175 hint.flags = PP_HOST_RESOLVER_PRIVATE_FLAGS_CANONNAME; 179 hint.flags = PP_HOST_RESOLVER_PRIVATE_FLAGS_CANONNAME;
176 return ParametrizedTestResolve(hint); 180 return ParametrizedTestResolve(hint);
177 } 181 }
178 182
179 std::string TestHostResolverPrivate::TestResolveIPv4() { 183 std::string TestHostResolverPrivate::TestResolveIPv4() {
180 PP_HostResolver_Private_Hint hint; 184 PP_HostResolver_Private_Hint hint;
181 hint.family = PP_NETADDRESSFAMILY_PRIVATE_IPV4; 185 hint.family = PP_NETADDRESSFAMILY_PRIVATE_IPV4;
182 hint.flags = PP_HOST_RESOLVER_PRIVATE_FLAGS_CANONNAME; 186 hint.flags = PP_HOST_RESOLVER_PRIVATE_FLAGS_CANONNAME;
183 return ParametrizedTestResolve(hint); 187 return ParametrizedTestResolve(hint);
184 } 188 }
OLDNEW
« no previous file with comments | « ppapi/tests/test_host_resolver.cc ('k') | ppapi/tests/test_memory.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698