Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(556)

Unified Diff: ppapi/tests/test_url_loader.cc

Issue 915403003: Enable size_t to int truncation warnings in PPAPI (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: ppapi_unittests win x64 Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ppapi/tests/test_udp_socket_private.cc ('k') | ppapi/tests/test_url_request.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/tests/test_url_loader.cc
diff --git a/ppapi/tests/test_url_loader.cc b/ppapi/tests/test_url_loader.cc
index 0d78efad6e994a2e74a5dc9ac0498f57066cd60a..d3a210e3bc177c4809631ba8745b6a2cb886d9f8 100644
--- a/ppapi/tests/test_url_loader.cc
+++ b/ppapi/tests/test_url_loader.cc
@@ -37,7 +37,7 @@ int32_t WriteEntireBuffer(PP_Instance instance,
TestCompletionCallback callback(instance, callback_type);
int32_t write_offset = offset;
const char* buf = data.c_str();
- int32_t size = data.size();
+ int32_t size = static_cast<int32_t>(data.size());
while (write_offset < offset + size) {
callback.WaitForResult(file_io->Write(write_offset,
@@ -343,7 +343,8 @@ std::string TestURLLoader::TestBasicPOST() {
request.SetURL("/echo");
request.SetMethod("POST");
std::string postdata("postdata");
- request.AppendDataToBody(postdata.data(), postdata.length());
+ request.AppendDataToBody(postdata.data(),
+ static_cast<uint32_t>(postdata.length()));
return LoadAndCompareBody(request, postdata);
}
@@ -394,9 +395,11 @@ std::string TestURLLoader::TestCompoundBodyPOST() {
request.SetURL("/echo");
request.SetMethod("POST");
std::string postdata1("post");
- request.AppendDataToBody(postdata1.data(), postdata1.length());
+ request.AppendDataToBody(postdata1.data(),
+ static_cast<uint32_t>(postdata1.length()));
std::string postdata2("data");
- request.AppendDataToBody(postdata2.data(), postdata2.length());
+ request.AppendDataToBody(postdata2.data(),
+ static_cast<uint32_t>(postdata2.length()));
return LoadAndCompareBody(request, postdata1 + postdata2);
}
@@ -416,7 +419,8 @@ std::string TestURLLoader::TestBinaryDataPOST() {
"\x00\x01\x02\x03\x04\x05postdata\xfa\xfb\xfc\xfd\xfe\xff";
std::string postdata(postdata_chars,
sizeof(postdata_chars) / sizeof(postdata_chars[0]));
- request.AppendDataToBody(postdata.data(), postdata.length());
+ request.AppendDataToBody(postdata.data(),
+ static_cast<uint32_t>(postdata.length()));
return LoadAndCompareBody(request, postdata);
}
@@ -433,7 +437,8 @@ std::string TestURLLoader::TestFailsBogusContentLength() {
request.SetMethod("POST");
request.SetHeaders("Content-Length: 400");
std::string postdata("postdata");
- request.AppendDataToBody(postdata.data(), postdata.length());
+ request.AppendDataToBody(postdata.data(),
+ static_cast<uint32_t>(postdata.length()));
int32_t rv;
rv = OpenUntrusted(request);
« no previous file with comments | « ppapi/tests/test_udp_socket_private.cc ('k') | ppapi/tests/test_url_request.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698