Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 9148086: Add simple NaCl gamepad example (Closed)

Created:
8 years, 11 months ago by scottmg
Modified:
8 years, 11 months ago
CC:
chromium-reviews, noelallen1
Visibility:
Public.

Description

Add simple NaCl gamepad example BUG=79098 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=118334

Patch Set 1 #

Patch Set 2 : rebase #

Total comments: 1

Patch Set 3 : fixes #

Patch Set 4 : update copyright years #

Patch Set 5 : update include for Makefile's -I #

Patch Set 6 : and in gamepad_module #

Unified diffs Side-by-side diffs Delta from patch set Stats (+476 lines, -0 lines) Patch
A native_client_sdk/src/examples/gamepad/Makefile View 1 2 3 1 chunk +183 lines, -0 lines 0 comments Download
A native_client_sdk/src/examples/gamepad/gamepad.h View 1 2 1 chunk +80 lines, -0 lines 0 comments Download
A native_client_sdk/src/examples/gamepad/gamepad.cc View 1 2 3 4 1 chunk +149 lines, -0 lines 0 comments Download
A native_client_sdk/src/examples/gamepad/gamepad.html View 1 1 chunk +24 lines, -0 lines 0 comments Download
A native_client_sdk/src/examples/gamepad/gamepad.nmf View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
A native_client_sdk/src/examples/gamepad/gamepad_module.cc View 1 2 3 4 5 1 chunk +34 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
scottmg
ppapi_proxy was here: http://codereview.chromium.org/9148044/ pepper was here: http://codereview.chromium.org/9085027/ This is just a basic example with ...
8 years, 11 months ago (2012-01-13 22:02:02 UTC) #1
bradn
So you'll wanna have a makefile, but I'm assuming you're leaving that to noel? http://codereview.chromium.org/9148086/diff/1001/native_client_sdk/src/examples/gamepad/gamepad.h ...
8 years, 11 months ago (2012-01-13 23:54:47 UTC) #2
noelallen1
Please add a: "Makefile" "gamepad.nmf" See the other C++ examples.
8 years, 11 months ago (2012-01-13 23:57:36 UTC) #3
scottmg
I was building using scons... did that just change I guess? The .nmf is .gitignored, ...
8 years, 11 months ago (2012-01-14 00:00:18 UTC) #4
scottmg
On 2012/01/13 23:57:36, noelallen1 wrote: > Please add a: > "Makefile" > "gamepad.nmf" > > ...
8 years, 11 months ago (2012-01-14 00:06:27 UTC) #5
scottmg
On 2012/01/13 23:57:36, noelallen1 wrote: > Please add a: > "Makefile" > "gamepad.nmf" > > ...
8 years, 11 months ago (2012-01-18 22:07:28 UTC) #6
noelallen1
Please run a try via: native_client_sdk/src/sdktry.sh This is a shortcut for "gcl try -b(SDKBOTS) ..." ...
8 years, 11 months ago (2012-01-18 22:50:53 UTC) #7
scottmg
On 2012/01/18 22:50:53, noelallen1 wrote: > Run a try, otherwise LGTM. Thanks!
8 years, 11 months ago (2012-01-19 18:14:41 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/9148086/9007
8 years, 11 months ago (2012-01-19 18:14:58 UTC) #9
commit-bot: I haz the power
8 years, 11 months ago (2012-01-19 19:35:23 UTC) #10
Change committed as 118334

Powered by Google App Engine
This is Rietveld 408576698