Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(481)

Unified Diff: components/gcm_driver/gcm_driver.h

Issue 914693002: Push API: Fix unsubscribing from GCM on Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Comment nits I missed earlier Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/gcm_driver/gcm_driver.h
diff --git a/components/gcm_driver/gcm_driver.h b/components/gcm_driver/gcm_driver.h
index 04fb53660dbd7db2ec8ee9603c895b46c1baab50..1a4344abc71f88cd0d88d194ff129c095ba76109 100644
--- a/components/gcm_driver/gcm_driver.h
+++ b/components/gcm_driver/gcm_driver.h
@@ -50,8 +50,11 @@ class GCMDriver {
// Unregisters an app from using GCM.
// |app_id|: application ID.
+ // |sender_ids|: list of the sender IDs that were passed when registering.
+ // On non-Android these are ignored.
// |callback|: to be called once the asynchronous operation is done.
void Unregister(const std::string& app_id,
+ const std::vector<std::string>& sender_ids,
const UnregisterCallback& callback);
// Sends a message to a given receiver.
@@ -144,7 +147,8 @@ class GCMDriver {
const std::vector<std::string>& sender_ids) = 0;
// Platform-specific implementation of Unregister.
- virtual void UnregisterImpl(const std::string& app_id) = 0;
+ virtual void UnregisterImpl(const std::string& app_id,
+ const std::vector<std::string>& sender_ids) = 0;
// Platform-specific implementation of Send.
virtual void SendImpl(const std::string& app_id,

Powered by Google App Engine
This is Rietveld 408576698