Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(500)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/extensions/extension_gcm_app_handler.cc

Issue 914693002: Push API: Fix unsubscribing from GCM on Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Comment nits I missed earlier Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/extensions/api/gcm/gcm_api.cc ('K') | « chrome/browser/extensions/api/gcm/gcm_api.cc ('k') | chrome/browser/services/gcm/fake_gcm_profile_service.cc » ('j') | content/browser/push_messaging/push_messaging_message_filter.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_gcm_app_handler.cc
diff --git a/chrome/browser/extensions/extension_gcm_app_handler.cc b/chrome/browser/extensions/extension_gcm_app_handler.cc
index 6a9f27538590fcbe1d3e37fd02c11e1cf78d389b..91ccb95b5159bbf5a2f6272c4debe496459f983c 100644
--- a/chrome/browser/extensions/extension_gcm_app_handler.cc
+++ b/chrome/browser/extensions/extension_gcm_app_handler.cc
@@ -135,9 +135,14 @@ void ExtensionGCMAppHandler::OnExtensionUninstalled(
content::BrowserContext* browser_context,
const Extension* extension,
extensions::UninstallReason reason) {
+#if defined(OS_ANDROID)
+#error If this ever gets ported to Android, you must pass the real sender ID.
jianli 2015/02/13 22:33:16 ditto.
johnme 2015/02/14 01:48:35 The patch no longer modifies this file.
+#endif
if (IsGCMPermissionEnabled(extension)) {
+ std::vector<std::string> sender_ids; // These are ignored on non-Android.
GetGCMDriver()->Unregister(
extension->id(),
+ sender_ids,
base::Bind(&ExtensionGCMAppHandler::OnUnregisterCompleted,
weak_factory_.GetWeakPtr(),
extension->id()));
« chrome/browser/extensions/api/gcm/gcm_api.cc ('K') | « chrome/browser/extensions/api/gcm/gcm_api.cc ('k') | chrome/browser/services/gcm/fake_gcm_profile_service.cc » ('j') | content/browser/push_messaging/push_messaging_message_filter.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698