components/gcm_driver/fake_gcm_driver.cc - Issue 914693002: Push API: Fix unsubscribing from GCM on Android

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/gcm_driver/fake_gcm_driver.cc

Issue 914693002: Push API: Fix unsubscribing from GCM on Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Comment nits I missed earlier Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/gcm_driver/fake_gcm_driver.cc

diff --git a/components/gcm_driver/fake_gcm_driver.cc b/components/gcm_driver/fake_gcm_driver.cc

index 45791f60899ad89731974c0421bbe1314aab45d5..8252425f99a24ff19c52b6790aa9168e92afffda 100644

--- a/components/gcm_driver/fake_gcm_driver.cc

+++ b/components/gcm_driver/fake_gcm_driver.cc

@@ -69,7 +69,8 @@ void FakeGCMDriver::RegisterImpl(const std::string& app_id,

const std::vector<std::string>& sender_ids) {

}

-void FakeGCMDriver::UnregisterImpl(const std::string& app_id) {

+void FakeGCMDriver::UnregisterImpl(const std::string& app_id,

+ const std::vector<std::string>& sender_ids) {

}

void FakeGCMDriver::SendImpl(const std::string& app_id,