components/gcm_driver/gcm_driver_desktop_unittest.cc - Issue 914693002: Push API: Fix unsubscribing from GCM on Android

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/gcm_driver/gcm_driver_desktop_unittest.cc

Issue 914693002: Push API: Fix unsubscribing from GCM on Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Now compiles and passes tests (and uses CHECK_EQ) Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/gcm_driver/gcm_driver_desktop_unittest.cc

diff --git a/components/gcm_driver/gcm_driver_desktop_unittest.cc b/components/gcm_driver/gcm_driver_desktop_unittest.cc

index e20081efd3c1f7cd7e3b9e36ae2ee13a91616316..b4f8c1e1a08482968a5f61f567c174c8c930a0f4 100644

--- a/components/gcm_driver/gcm_driver_desktop_unittest.cc

+++ b/components/gcm_driver/gcm_driver_desktop_unittest.cc

@@ -294,9 +294,11 @@ void GCMDriverTest::Unregister(const std::string& app_id,

WaitToFinish wait_to_finish) {

base::RunLoop run_loop;

async_operation_completed_callback_ = run_loop.QuitClosure();

+ std::vector<std::string> sender_ids; // These are ignored on desktop.

driver_->Unregister(app_id,

- base::Bind(&GCMDriverTest::UnregisterCompleted,

- base::Unretained(this)));

+ sender_ids,

+ base::Bind(&GCMDriverTest::UnregisterCompleted,

+ base::Unretained(this)));

if (wait_to_finish == WAIT)

run_loop.Run();

}