Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8051)

Unified Diff: components/gcm_driver/gcm_driver_desktop.cc

Issue 914693002: Push API: Fix unsubscribing from GCM on Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Now compiles and passes tests (and uses CHECK_EQ) Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/gcm_driver/gcm_driver_desktop.cc
diff --git a/components/gcm_driver/gcm_driver_desktop.cc b/components/gcm_driver/gcm_driver_desktop.cc
index 6a9153986819f84471c5c6d49f7df3d8c5201986..4d32c37153c906c555eded6d51b38251842bf3af 100644
--- a/components/gcm_driver/gcm_driver_desktop.cc
+++ b/components/gcm_driver/gcm_driver_desktop.cc
@@ -522,7 +522,8 @@ void GCMDriverDesktop::DoRegister(const std::string& app_id,
sender_ids));
}
-void GCMDriverDesktop::UnregisterImpl(const std::string& app_id) {
+void GCMDriverDesktop::UnregisterImpl(const std::string& app_id,
+ const std::vector<std::string>& unused) {
jianli 2015/02/12 20:03:31 Probably it is a bit better to write this as con
johnme 2015/02/13 19:11:56 Done.
// Delay the unregister operation until GCMClient is ready.
if (!delayed_task_controller_->CanRunTaskWithoutDelay()) {
delayed_task_controller_->AddTask(

Powered by Google App Engine
This is Rietveld 408576698