components/invalidation/gcm_invalidation_bridge.cc - Issue 914693002: Push API: Fix unsubscribing from GCM on Android

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/invalidation/gcm_invalidation_bridge.cc

Issue 914693002: Push API: Fix unsubscribing from GCM on Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Now compiles and passes tests (and uses CHECK_EQ) Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/invalidation/gcm_invalidation_bridge.cc

diff --git a/components/invalidation/gcm_invalidation_bridge.cc b/components/invalidation/gcm_invalidation_bridge.cc

index ef09594c2b710b1fe4e7d67d22ca4f4b361b6c6c..d07ef966d4ff9c356b4e24b3ec3bdb074d34b626 100644

--- a/components/invalidation/gcm_invalidation_bridge.cc

+++ b/components/invalidation/gcm_invalidation_bridge.cc

@@ -286,8 +286,11 @@ void GCMInvalidationBridge::Unregister() {

if (gcm_driver_ == NULL)

return;

+ std::vector<std::string> sender_ids;

+ sender_ids.push_back(kInvalidationsSenderId);

gcm_driver_->Unregister(

kInvalidationsAppId,

+ sender_ids,

base::Bind(&GCMInvalidationBridge::UnregisterFinishedNoOp));

}