[App banners] Start adding unit tets

[App banners] Start adding unit tets

Add basic unit tests for ensuring that the banner appears,
appears after being ignored, and appears after being blocked.

BUG=457414
TEST=AppBannerManagerTest

Committed: https://crrev.com/4bd580644cea7086dbbe9a0ef39ffd8c1dbe70b9
Cr-Commit-Position: refs/heads/master@{#316690}

[gone, 2015-02-14 01:29:27]

https://codereview.chromium.org/914403006/diff/1/chrome/browser/android/banne...
File chrome/browser/android/banners/app_banner_manager.cc (right):

https://codereview.chromium.org/914403006/diff/1/chrome/browser/android/banne...
chrome/browser/android/banners/app_banner_manager.cc:263: return fetcher_.get()
? 1 : 0;
Forked off from another CL which has multiple fetchers running.  This will be
updated in that CL.

[gone, 2015-02-14 01:29:37]

dfalcantara@chromium.org changed reviewers:
+ tedchoc@chromium.org

[Ted C, 2015-02-17 18:12:20]

lgtm

https://codereview.chromium.org/914403006/diff/1/chrome/android/java/src/org/...
File
chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java
(right):

https://codereview.chromium.org/914403006/diff/1/chrome/android/java/src/org/...
chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java:143:
/** Sets a constant that gets added to the time when the current time is
requested. */
I would add (in days) somewhere in the comment.

https://codereview.chromium.org/914403006/diff/1/chrome/android/javatests/src...
File
chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java
(right):

https://codereview.chromium.org/914403006/diff/1/chrome/android/javatests/src...
chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java:82:
clearAppData();
does this not happen by default?  I thought newt@ made it so, but maybe not for
chrome shell?

https://codereview.chromium.org/914403006/diff/1/chrome/android/javatests/src...
chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java:123:
return TextUtils.equals(textView.getText(), "Mock app title");
Make "Mock app title" a constant to share with the details delegate above.

https://codereview.chromium.org/914403006/diff/1/chrome/android/javatests/src...
chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java:128:
public void testBannerAppears() throws Exception {
all of these need size annotations (and probably feature stuff as well).

[gone, 2015-02-17 19:14:28]

New patchsets have been uploaded after l-g-t-m from tedchoc@chromium.org

[gone, 2015-02-17 19:14:42]

https://codereview.chromium.org/914403006/diff/1/chrome/android/java/src/org/...
File
chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java
(right):

https://codereview.chromium.org/914403006/diff/1/chrome/android/java/src/org/...
chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java:143:
/** Sets a constant that gets added to the time when the current time is
requested. */
On 2015/02/17 18:12:20, Ted C wrote:
> I would add (in days) somewhere in the comment.

Done.

https://codereview.chromium.org/914403006/diff/1/chrome/android/javatests/src...
File
chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java
(right):

https://codereview.chromium.org/914403006/diff/1/chrome/android/javatests/src...
chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java:82:
clearAppData();
On 2015/02/17 18:12:20, Ted C wrote:
> does this not happen by default?  I thought newt@ made it so, but maybe not
for
> chrome shell?

Yeah, not seeing it get called in ChromeShellTestBase.  It's called from
ChromeActivityTestBase, though.

https://codereview.chromium.org/914403006/diff/1/chrome/android/javatests/src...
chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java:123:
return TextUtils.equals(textView.getText(), "Mock app title");
On 2015/02/17 18:12:20, Ted C wrote:
> Make "Mock app title" a constant to share with the details delegate above.

Done.

https://codereview.chromium.org/914403006/diff/1/chrome/android/javatests/src...
chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java:128:
public void testBannerAppears() throws Exception {
On 2015/02/17 18:12:20, Ted C wrote:
> all of these need size annotations (and probably feature stuff as well).

Done.

https://codereview.chromium.org/914403006/diff/1/chrome/android/javatests/src...
chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java:128:
public void testBannerAppears() throws Exception {
On 2015/02/17 18:12:20, Ted C wrote:
> all of these need size annotations (and probably feature stuff as well).

Done.

[gone, 2015-02-17 19:14:45]

The CQ bit was checked by dfalcantara@chromium.org

[commit-bot: I haz the power, 2015-02-17 19:16:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/914403006/20001

[commit-bot: I haz the power, 2015-02-17 21:28:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-17 21:28:13]

Try jobs failed on following builders:
  android_rel_tests_recipe on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_rel_tes...)

[gone, 2015-02-17 21:53:50]

The CQ bit was checked by dfalcantara@chromium.org

[commit-bot: I haz the power, 2015-02-17 21:54:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/914403006/20001

[commit-bot: I haz the power, 2015-02-17 22:57:45]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-02-17 22:58:50]

Patchset 2 (id:??) landed as
https://crrev.com/4bd580644cea7086dbbe9a0ef39ffd8c1dbe70b9
Cr-Commit-Position: refs/heads/master@{#316690}