[App banners] Start adding unit tets

chrome/browser/android/banners/app_banner_manager.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/android/banners/app_banner_manager.h"
 
 #include "base/android/jni_android.h"
 #include "base/android/jni_string.h"
 #include "base/bind.h"
 #include "base/command_line.h"
@@ skipping 26 matching lines @@
 #include "ui/gfx/android/java_bitmap.h"
 #include "ui/gfx/screen.h"
 
 using base::android::ConvertJavaStringToUTF8;
 using base::android::ConvertJavaStringToUTF16;
 using base::android::ConvertUTF8ToJavaString;
 using base::android::ConvertUTF16ToJavaString;
 
 namespace {
 const char kBannerTag[] = "google-play-id";
+base::TimeDelta gTimeDeltaForTesting;
 }
 
 namespace banners {
 
 AppBannerManager::AppBannerManager(JNIEnv* env, jobject obj)
     : weak_java_banner_view_manager_(env, obj), weak_factory_(this) {
 }
 
 AppBannerManager::~AppBannerManager() {
 }
@@ skipping 80 matching lines @@
       return;
 
     FetchIcon(icon_url);
   }
 }
 
 void AppBannerManager::RecordCouldShowBanner(
     const std::string& package_or_start_url) {
   AppBannerSettingsHelper::RecordBannerEvent(
       web_contents(), validated_url_, package_or_start_url,
-      AppBannerSettingsHelper::APP_BANNER_EVENT_COULD_SHOW, base::Time::Now());
+      AppBannerSettingsHelper::APP_BANNER_EVENT_COULD_SHOW, GetCurrentTime());
 }
 
 bool AppBannerManager::CheckIfShouldShow(
     const std::string& package_or_start_url) {
   if (!AppBannerSettingsHelper::ShouldShowBanner(web_contents(), validated_url_,
                                                  package_or_start_url,
-                                                 base::Time::Now())) {
+                                                 GetCurrentTime())) {
     return false;
   }
 
   AppBannerSettingsHelper::RecordBannerEvent(
       web_contents(), validated_url_, package_or_start_url,
-      AppBannerSettingsHelper::APP_BANNER_EVENT_DID_SHOW, base::Time::Now());
+      AppBannerSettingsHelper::APP_BANNER_EVENT_DID_SHOW, GetCurrentTime());
   return true;
 }
 
 bool AppBannerManager::OnMessageReceived(const IPC::Message& message) {
   bool handled = true;
   IPC_BEGIN_MESSAGE_MAP(AppBannerManager, message)
     IPC_MESSAGE_HANDLER(ChromeViewHostMsg_DidRetrieveMetaTagContent,
                         OnDidRetrieveMetaTagContent)
     IPC_MESSAGE_UNHANDLED(handled = false)
   IPC_END_MESSAGE_MAP()
@@ skipping 80 matching lines @@
   if (validated_url_ != web_contents()->GetURL())
     return false;
 
   std::string image_url = ConvertJavaStringToUTF8(env, jicon_url);
   app_title_ = ConvertJavaStringToUTF16(env, japp_title);
   native_app_package_ = ConvertJavaStringToUTF8(env, japp_package);
   native_app_data_.Reset(env, japp_data);
   return FetchIcon(GURL(image_url));
 }
 
+int AppBannerManager::GetNumActiveFetchers(JNIEnv* env, jobject obj) {
+  return fetcher_.get() ? 1 : 0;

[gone, 2015/02/14 01:29:27]

Forked off from another CL which has multiple fetchers running.  This will be
updated in that CL.

+}
+
 bool AppBannerManager::FetchIcon(const GURL& image_url) {
   if (!web_contents())
     return false;
 
   // Begin asynchronously fetching the app icon.
   Profile* profile =
       Profile::FromBrowserContext(web_contents()->GetBrowserContext());
   fetcher_.reset(new chrome::BitmapFetcher(image_url, this));
   fetcher_.get()->Start(
       profile->GetRequestContext(),
       std::string(),
       net::URLRequest::CLEAR_REFERRER_ON_TRANSITION_FROM_SECURE_TO_INSECURE,
       net::LOAD_NORMAL);
   app_icon_url_ = image_url;
   return true;
 }
 
 int AppBannerManager::GetPreferredIconSize() {
   JNIEnv* env = base::android::AttachCurrentThread();
   ScopedJavaLocalRef<jobject> jobj = weak_java_banner_view_manager_.get(env);
   if (jobj.is_null())
     return 0;
 
   return Java_AppBannerManager_getPreferredIconSize(env, jobj.obj());
 }
 
+// static
+base::Time AppBannerManager::GetCurrentTime() {
+  return base::Time::Now() + gTimeDeltaForTesting;
+}
+
 void RecordDismissEvent(JNIEnv* env, jclass clazz, jint metric) {
   banners::TrackDismissEvent(metric);
 }
 
 void RecordInstallEvent(JNIEnv* env, jclass clazz, jint metric) {
   banners::TrackInstallEvent(metric);
 }
 
 jlong Init(JNIEnv* env, jobject obj) {
   AppBannerManager* manager = new AppBannerManager(env, obj);
   return reinterpret_cast<intptr_t>(manager);
 }
 
 jboolean IsEnabled(JNIEnv* env, jclass clazz) {
   return base::CommandLine::ForCurrentProcess()->HasSwitch(
       switches::kEnableAppInstallAlerts);
 }
 
+void SetTimeDeltaForTesting(JNIEnv* env, jclass clazz, jint days) {
+  gTimeDeltaForTesting = base::TimeDelta::FromDays(days);
+}
+
 // Register native methods
 bool RegisterAppBannerManager(JNIEnv* env) {
   return RegisterNativesImpl(env);
 }
 
 }  // namespace banners