Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(889)

Unified Diff: chrome/browser/android/banners/app_banner_infobar_delegate.cc

Issue 914403006: [App banners] Start adding unit tets (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Comments Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/banners/app_banner_infobar_delegate.cc
diff --git a/chrome/browser/android/banners/app_banner_infobar_delegate.cc b/chrome/browser/android/banners/app_banner_infobar_delegate.cc
index cc9415c630f611920361411fa3c9fbc49a1d5def..18f146f7c8688d8575398cecb799c1b36625fd11 100644
--- a/chrome/browser/android/banners/app_banner_infobar_delegate.cc
+++ b/chrome/browser/android/banners/app_banner_infobar_delegate.cc
@@ -10,6 +10,7 @@
#include "base/strings/string16.h"
#include "base/strings/utf_string_conversions.h"
#include "base/threading/worker_pool.h"
+#include "chrome/browser/android/banners/app_banner_manager.h"
#include "chrome/browser/android/shortcut_helper.h"
#include "chrome/browser/android/shortcut_info.h"
#include "chrome/browser/android/tab_android.h"
@@ -114,12 +115,14 @@ void AppBannerInfoBarDelegate::InfoBarDismissed() {
AppBannerSettingsHelper::RecordBannerEvent(
web_contents, web_contents->GetURL(),
native_app_package_,
- AppBannerSettingsHelper::APP_BANNER_EVENT_DID_BLOCK, base::Time::Now());
+ AppBannerSettingsHelper::APP_BANNER_EVENT_DID_BLOCK,
+ AppBannerManager::GetCurrentTime());
} else if (!web_app_data_.IsEmpty()) {
AppBannerSettingsHelper::RecordBannerEvent(
web_contents, web_contents->GetURL(),
web_app_data_.start_url.spec(),
- AppBannerSettingsHelper::APP_BANNER_EVENT_DID_BLOCK, base::Time::Now());
+ AppBannerSettingsHelper::APP_BANNER_EVENT_DID_BLOCK,
+ AppBannerManager::GetCurrentTime());
}
}
@@ -146,7 +149,7 @@ bool AppBannerInfoBarDelegate::Accept() {
web_contents, web_contents->GetURL(),
web_app_data_.start_url.spec(),
AppBannerSettingsHelper::APP_BANNER_EVENT_DID_ADD_TO_HOMESCREEN,
- base::Time::Now());
+ AppBannerManager::GetCurrentTime());
ShortcutInfo info;
info.UpdateFromManifest(web_app_data_);
@@ -201,7 +204,7 @@ void AppBannerInfoBarDelegate::OnInstallIntentReturned(
web_contents->GetURL(),
native_app_package_,
AppBannerSettingsHelper::APP_BANNER_EVENT_DID_ADD_TO_HOMESCREEN,
- base::Time::Now());
+ AppBannerManager::GetCurrentTime());
}
UpdateInstallState(env, obj);

Powered by Google App Engine
This is Rietveld 408576698