Tap on the video element toggles controls visibility

Source/core/html/shadow/MediaControlElements.cpp

Index: Source/core/html/shadow/MediaControlElements.cpp
diff --git a/Source/core/html/shadow/MediaControlElements.cpp b/Source/core/html/shadow/MediaControlElements.cpp
index c9e4573375d568b0a7b1db700132ae26b737da41..4a6bca3caa28aec3a256cd8ffbcd49461146570d 100644
--- a/Source/core/html/shadow/MediaControlElements.cpp
+++ b/Source/core/html/shadow/MediaControlElements.cpp
@@ -377,6 +377,9 @@ void MediaControlTimelineElement::defaultEventHandler(Event* event)
     if (event->type() == EventTypeNames::mouseup)
         mediaControls().endScrubbing();
 
+    if (event->type() == EventTypeNames::touchmove)
+        mediaControls().timelineKnobDragged();

[philipj_slow, 2015/02/16 10:45:18]

Isn't this fixing an unrelated problem, perhaps the same as the recently fixed
https://code.google.com/p/chromium/issues/detail?id=454304 ?

[Tima Vaisburd, 2015/02/16 20:32:11]

I might also say "related, but different problem". Yes, maybe it does not belong
in here.
I saw your change that you refer in here. As far as I can see your change does
not fix that particular scenario (i.e. a user presses and drags back and forth
without stopping).

[philipj_slow, 2015/02/17 02:37:24]

My change was just cleanup, https://codereview.chromium.org/892963003 was the
actual fix.

Anyway, unless this problem only surfaces because of the "touch to show/hide"
changes, I suggest a separate CL and test for it.

+
     MediaControlInputElement::defaultEventHandler(event);
 
     if (event->type() == EventTypeNames::mouseover || event->type() == EventTypeNames::mouseout || event->type() == EventTypeNames::mousemove)