Source/core/html/shadow/MediaControls.h - Issue 914043002: Tap on the video element toggles controls visibility

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/shadow/MediaControls.h

Issue 914043002: Tap on the video element toggles controls visibility (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebased, process mouse only for non-synthetic events. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/html/shadow/MediaControlElements.cpp ('K') | « Source/core/html/shadow/MediaControlElements.cpp ('k') | Source/core/html/shadow/MediaControls.cpp » ('j') | Source/core/html/shadow/MediaControls.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/html/shadow/MediaControls.h

diff --git a/Source/core/html/shadow/MediaControls.h b/Source/core/html/shadow/MediaControls.h

index b9a87e53a06298cc20070248cf7c09fa20c74876..5d854331d7728f930fc8ee5b150d1cb753648f27 100644

--- a/Source/core/html/shadow/MediaControls.h

+++ b/Source/core/html/shadow/MediaControls.h

@@ -59,6 +59,7 @@ public:

void changedClosedCaptionsVisibility();

void refreshClosedCaptionsButtonVisibility();

void textTracksChanged();

+ void timelineKnobDragged();

void enteredFullscreen();

void exitedFullscreen();

@@ -111,6 +112,8 @@ private:

virtual void defaultEventHandler(Event*) override;

bool containsRelatedTarget(Event*);

+ bool isInactiveElement(Node*) const;

RawPtrWillBeMember<HTMLMediaElement> m_mediaElement;

// Container for the media control elements.