Tap on the video element toggles controls visibility

Source/core/html/shadow/MediaControlElements.cpp

 /*
  * Copyright (C) 2008, 2009, 2010, 2011 Apple Inc. All rights reserved.
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
@@ skipping 359 matching lines @@
 
     if (!inDocument() || !document().isActive())
         return;
 
     if (event->type() == EventTypeNames::mousedown)
         mediaControls().beginScrubbing();
 
     if (event->type() == EventTypeNames::mouseup)
         mediaControls().endScrubbing();
 
+    if (event->type() == EventTypeNames::touchmove)
+        mediaControls().timelineKnobDragged();

[philipj_slow, 2015/02/16 10:45:18]

Isn't this fixing an unrelated problem, perhaps the same as the recently fixed
https://code.google.com/p/chromium/issues/detail?id=454304 ?

[Tima Vaisburd, 2015/02/16 20:32:11]

I might also say "related, but different problem". Yes, maybe it does not belong
in here.
I saw your change that you refer in here. As far as I can see your change does
not fix that particular scenario (i.e. a user presses and drags back and forth
without stopping).

[philipj_slow, 2015/02/17 02:37:24]

My change was just cleanup, https://codereview.chromium.org/892963003 was the
actual fix.

Anyway, unless this problem only surfaces because of the "touch to show/hide"
changes, I suggest a separate CL and test for it.

+
     MediaControlInputElement::defaultEventHandler(event);
 
     if (event->type() == EventTypeNames::mouseover || event->type() == EventTypeNames::mouseout || event->type() == EventTypeNames::mousemove)
         return;
 
     double time = value().toDouble();
     if (event->type() == EventTypeNames::input) {
         // FIXME: This will need to take the timeline offset into consideration
         // once that concept is supported, see https://crbug.com/312699
         if (mediaElement().controller()) {
@@ skipping 319 matching lines @@
     float fontSize = smallestDimension * 0.05f;
     if (fontSize != m_fontSize) {
         m_fontSize = fontSize;
         setInlineStyleProperty(CSSPropertyFontSize, fontSize, CSSPrimitiveValue::CSS_PX);
     }
 }
 
 // ----------------------------
 
 } // namespace blink