Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issue 913373002: Update Chomium's build files to work w/ latest GN binaries. (Closed)

Created:
5 years, 10 months ago by Dirk Pranke
Modified:
5 years, 10 months ago
Reviewers:
brettw, ddorwin
CC:
chromium-reviews, sadrul, qsr+mojo_chromium.org, urvang, chromoting-reviews_chromium.org, skal, yzshen+watch_chromium.org, vikasa, ben+mojo_chromium.org, cbentzel+watch_chromium.org, grt+watch_chromium.org, viettrungluu+watch_chromium.org, jam, abarth-chromium, eme-reviews_chromium.org, darin-cc_chromium.org, kalyank, erikwright+watch_chromium.org, mlamouri+watch-content_chromium.org, rickyz+watch_chromium.org, feature-media-reviews_chromium.org, caitkp+watch_chromium.org, piman+watch_chromium.org, mkwst+moarreviews-shell_chromium.org, jochen+watch_chromium.org, jzern, Dai Mikurube (NOT FULLTIME), wfh+watch_chromium.org, Aaron Boodman, darin (slow to review), jln+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@gn_cpu_arch_changes
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update Chomium's build files to work w/ latest GN binaries. The latest GN binaries rename cpu_arch to current_cpu and/or target_cpu as appropriate, build_cpu_arch to host_cpu, and os to current_os and target_os as appropriate. R=brettw@chromium.org TBR=ddorwin@chromium.org EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg BUG=344767 Committed: https://crrev.com/4327621a322c964a8bc6d1ef5a4534f0f877d63e Cr-Commit-Position: refs/heads/master@{#317223}

Patch Set 1 : cleanup / review #

Total comments: 1

Patch Set 2 : rebase on top of backwards-compat //build changes #

Patch Set 3 : merge to #316930 #

Patch Set 4 : merge to #317214 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+237 lines, -234 lines) Patch
M BUILD.gn View 1 2 1 chunk +1 line, -1 line 0 comments Download
M base/allocator/BUILD.gn View 1 2 1 chunk +1 line, -1 line 0 comments Download
M breakpad/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M build/compiled_action.gni View 1 chunk +1 line, -1 line 0 comments Download
M build/config/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M build/config/BUILDCONFIG.gn View 1 2 3 11 chunks +39 lines, -36 lines 0 comments Download
M build/config/allocator.gni View 1 chunk +1 line, -1 line 0 comments Download
M build/config/android/config.gni View 1 2 3 4 chunks +16 lines, -16 lines 0 comments Download
M build/config/arm.gni View 1 chunk +1 line, -1 line 0 comments Download
M build/config/compiler/BUILD.gn View 1 2 3 16 chunks +20 lines, -20 lines 0 comments Download
M build/config/features.gni View 1 chunk +3 lines, -3 lines 0 comments Download
M build/config/linux/pkg_config.gni View 1 chunk +1 line, -1 line 0 comments Download
M build/config/mips.gni View 1 chunk +2 lines, -2 lines 0 comments Download
M build/config/sysroot.gni View 1 2 3 2 chunks +9 lines, -9 lines 0 comments Download
M build/config/win/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M build/secondary/third_party/libjpeg_turbo/BUILD.gn View 5 chunks +8 lines, -8 lines 0 comments Download
M build/secondary/third_party/libsrtp/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M build/secondary/third_party/nss/BUILD.gn View 1 2 3 8 chunks +9 lines, -13 lines 0 comments Download
M build/toolchain/android/BUILD.gn View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M build/toolchain/gcc_toolchain.gni View 1 1 chunk +4 lines, -4 lines 0 comments Download
M build/toolchain/mac/BUILD.gn View 1 2 1 chunk +1 line, -1 line 0 comments Download
M build/toolchain/nacl/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M build/toolchain/win/BUILD.gn View 1 2 5 chunks +5 lines, -5 lines 0 comments Download
M build/toolchain/win/midl.gni View 1 chunk +2 lines, -2 lines 0 comments Download
M build/toolchain/win/setup_toolchain.py View 1 2 4 chunks +13 lines, -13 lines 0 comments Download
M build/vs_toolchain.py View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/BUILD.gn View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/BUILD.gn View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M chrome_elf/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M components/policy/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M content/common/BUILD.gn View 1 2 3 4 chunks +5 lines, -5 lines 0 comments Download
M content/gpu/BUILD.gn View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/shell/android/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M courgette/BUILD.gn View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M media/BUILD.gn View 1 2 3 5 chunks +5 lines, -4 lines 0 comments Download
M media/base/BUILD.gn View 1 2 5 chunks +6 lines, -6 lines 0 comments Download
M mojo/nacl/BUILD.gn View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M net/BUILD.gn View 1 2 3 8 chunks +8 lines, -1 line 0 comments Download
M ppapi/shared_impl/BUILD.gn View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M ppapi/thunk/BUILD.gn View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M remoting/resources/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M sandbox/linux/BUILD.gn View 1 2 1 chunk +1 line, -1 line 0 comments Download
M sandbox/win/BUILD.gn View 1 2 3 3 chunks +4 lines, -4 lines 0 comments Download
M skia/BUILD.gn View 1 2 6 chunks +6 lines, -6 lines 0 comments Download
M third_party/adobe/flash/BUILD.gn View 1 chunk +6 lines, -6 lines 0 comments Download
M third_party/boringssl/BUILD.gn View 1 2 3 5 chunks +7 lines, -6 lines 0 comments Download
M third_party/harfbuzz-ng/BUILD.gn View 1 2 3 2 chunks +2 lines, -4 lines 0 comments Download
M third_party/libjingle/BUILD.gn View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/libwebp/BUILD.gn View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/opus/BUILD.gn View 2 chunks +5 lines, -4 lines 0 comments Download
M third_party/qcms/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/widevine/cdm/BUILD.gn View 1 2 1 chunk +1 line, -1 line 3 comments Download
M third_party/yasm/BUILD.gn View 1 2 3 1 chunk +2 lines, -6 lines 0 comments Download
M third_party/yasm/yasm_assemble.gni View 4 chunks +7 lines, -7 lines 0 comments Download
M third_party/zlib/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
Dirk Pranke
5 years, 10 months ago (2015-02-12 03:20:25 UTC) #2
brettw
LGTM https://codereview.chromium.org/913373002/diff/20001/ppapi/BUILD.gn File ppapi/BUILD.gn (right): https://codereview.chromium.org/913373002/diff/20001/ppapi/BUILD.gn#newcode392 ppapi/BUILD.gn:392: if (is_win && current_cpu == "x64" && current_toolchain ...
5 years, 10 months ago (2015-02-12 18:04:32 UTC) #3
Dirk Pranke
This patch depends on https://codereview.chromium.org/936103003/ landing first ...
5 years, 10 months ago (2015-02-19 00:18:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/913373002/80001
5 years, 10 months ago (2015-02-20 02:35:47 UTC) #8
ddorwin
https://codereview.chromium.org/913373002/diff/80001/third_party/widevine/cdm/BUILD.gn File third_party/widevine/cdm/BUILD.gn (right): https://codereview.chromium.org/913373002/diff/80001/third_party/widevine/cdm/BUILD.gn#newcode5 third_party/widevine/cdm/BUILD.gn:5: widevine_arch = current_cpu The description says "current_cpu_arch", but multiple ...
5 years, 10 months ago (2015-02-20 02:47:08 UTC) #9
Dirk Pranke
On 2015/02/20 02:47:08, ddorwin wrote: > https://codereview.chromium.org/913373002/diff/80001/third_party/widevine/cdm/BUILD.gn > File third_party/widevine/cdm/BUILD.gn (right): > > https://codereview.chromium.org/913373002/diff/80001/third_party/widevine/cdm/BUILD.gn#newcode5 > ...
5 years, 10 months ago (2015-02-20 02:47:42 UTC) #10
ddorwin
third_party/widevine/cdm/ LGTM, though I can't say whether it should be current_cpu or target_cpu. https://codereview.chromium.org/913373002/diff/80001/third_party/widevine/cdm/BUILD.gn File ...
5 years, 10 months ago (2015-02-20 02:53:35 UTC) #11
commit-bot: I haz the power
Committed patchset #4 (id:80001)
5 years, 10 months ago (2015-02-20 02:55:32 UTC) #12
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/4327621a322c964a8bc6d1ef5a4534f0f877d63e Cr-Commit-Position: refs/heads/master@{#317223}
5 years, 10 months ago (2015-02-20 02:56:19 UTC) #13
Dirk Pranke
5 years, 10 months ago (2015-02-20 03:00:26 UTC) #14
Message was sent while issue was closed.
https://codereview.chromium.org/913373002/diff/80001/third_party/widevine/cdm...
File third_party/widevine/cdm/BUILD.gn (right):

https://codereview.chromium.org/913373002/diff/80001/third_party/widevine/cdm...
third_party/widevine/cdm/BUILD.gn:5: widevine_arch = current_cpu
On 2015/02/20 02:53:35, ddorwin wrote:
> What is the difference between current_cpu and target_cpu? It sounds like
> neither are the host so either would work here.

generally you want current_cpu (the cpu of the current toolchain).

Probably the only time you want to look at target_cpu instead is if you're
building something on one architecture (usually the host) but what you build
depends on what the target will ultimately be. V8 has this, where they
precompile some JS on the host but how they precompile it varies.

Powered by Google App Engine
This is Rietveld 408576698