Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4291)

Unified Diff: build/toolchain/win/BUILD.gn

Issue 913373002: Update Chomium's build files to work w/ latest GN binaries. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@gn_cpu_arch_changes
Patch Set: merge to #317214 Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/toolchain/win/BUILD.gn
diff --git a/build/toolchain/win/BUILD.gn b/build/toolchain/win/BUILD.gn
index 099d91abdf12ff1f9b6e25b73b3edd62ba324d96..e9461a4644b4f5a88174cecb1216209cf04b7dcd 100644
--- a/build/toolchain/win/BUILD.gn
+++ b/build/toolchain/win/BUILD.gn
@@ -31,7 +31,7 @@ toolchain_data = exec_script("setup_toolchain.py",
gyp_win_tool_path,
windows_sdk_path,
visual_studio_runtime_dirs,
- cpu_arch,
+ current_cpu,
],
"scope")
@@ -43,7 +43,7 @@ if (vc_bin_dir == "") {
concurrent_links = exec_script("../get_concurrent_links.py", [], "value")
# Parameters:
-# cpu_arch: cpu_arch to pass as a build arg
+# current_cpu: current_cpu to pass as a build arg
# environment: File name of environment file.
template("msvc_toolchain") {
if (defined(invoker.concurrent_links)) {
@@ -62,7 +62,7 @@ template("msvc_toolchain") {
"copy_dlls",
rebase_path(root_build_dir),
configuration,
- invoker.cpu_arch,
+ invoker.current_cpu,
])
if (use_goma) {
@@ -212,7 +212,7 @@ template("msvc_toolchain") {
# get it sorted out how we want to support them both in a single build.
# Right now only one of these can be enabled at a time because the
# runtime libraries get copied to root_build_dir and would collide.
-if (cpu_arch == "x86") {
+if (current_cpu == "x86") {
msvc_toolchain("32") {
environment = "environment.x86"
@@ -220,7 +220,7 @@ if (cpu_arch == "x86") {
}
}
-if (cpu_arch == "x64") {
+if (current_cpu == "x64") {
msvc_toolchain("64") {
environment = "environment.x64"

Powered by Google App Engine
This is Rietveld 408576698