Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(521)

Issue 913253002: Fix clipboard permission callbacks to account for default values. (Closed)

Created:
5 years, 10 months ago by dcheng
Modified:
5 years, 10 months ago
CC:
chromium-reviews, sky
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix clipboard permission callbacks to account for default values. Blink allows copy/cut to be triggered with a user gesture, but the chrome implementation of WebPermissionsClient was clobbering that bit of information. BUG=424968 Committed: https://crrev.com/07d72f48a5603798519b459eed83eb4a68b10069 Cr-Commit-Position: refs/heads/master@{#316269}

Patch Set 1 #

Patch Set 2 : ScriptContext is more prevalent than I thought #

Patch Set 3 : Sort of test #

Patch Set 4 : Fix another test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -10 lines) Patch
M chrome/browser/extensions/content_capabilities_browsertest.cc View 1 2 3 4 chunks +12 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extension_dom_clipboard_apitest.cc View 1 2 1 chunk +5 lines, -2 lines 0 comments Download
M chrome/renderer/content_settings_observer.cc View 1 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 17 (6 generated)
dcheng
The test coverage is incomplete, but I wasn't able to find a simple way to ...
5 years, 10 months ago (2015-02-11 20:53:04 UTC) #2
sky
LGTM
5 years, 10 months ago (2015-02-11 20:56:50 UTC) #4
not at google - send to devlin
lgtm
5 years, 10 months ago (2015-02-11 22:28:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/913253002/40001
5 years, 10 months ago (2015-02-12 18:18:40 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/24331)
5 years, 10 months ago (2015-02-12 19:23:53 UTC) #9
dcheng
kalman@, mind taking a look at the content_capabilities_browsertest.cc changes?
5 years, 10 months ago (2015-02-12 21:12:35 UTC) #11
dcheng
ping =)
5 years, 10 months ago (2015-02-13 18:30:56 UTC) #12
not at google - send to devlin
heh, oh well. lgtm.
5 years, 10 months ago (2015-02-13 18:41:34 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/913253002/60001
5 years, 10 months ago (2015-02-13 18:45:06 UTC) #15
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 10 months ago (2015-02-13 20:13:40 UTC) #16
commit-bot: I haz the power
5 years, 10 months ago (2015-02-13 20:14:16 UTC) #17
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/07d72f48a5603798519b459eed83eb4a68b10069
Cr-Commit-Position: refs/heads/master@{#316269}

Powered by Google App Engine
This is Rietveld 408576698