Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Side by Side Diff: chrome/browser/extensions/extension_dom_clipboard_apitest.cc

Issue 913253002: Fix clipboard permission callbacks to account for default values. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix another test Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/strings/stringprintf.h" 5 #include "base/strings/stringprintf.h"
6 #include "chrome/browser/extensions/extension_apitest.h" 6 #include "chrome/browser/extensions/extension_apitest.h"
7 #include "chrome/browser/ui/browser.h" 7 #include "chrome/browser/ui/browser.h"
8 #include "chrome/browser/ui/tabs/tab_strip_model.h" 8 #include "chrome/browser/ui/tabs/tab_strip_model.h"
9 #include "chrome/test/base/ui_test_utils.h" 9 #include "chrome/test/base/ui_test_utils.h"
10 #include "content/public/browser/web_contents.h" 10 #include "content/public/browser/web_contents.h"
(...skipping 94 matching lines...) Expand 10 before | Expand all | Expand 10 after
105 EXPECT_TRUE(ExecuteCopyInSelectedTab()) << message_; 105 EXPECT_TRUE(ExecuteCopyInSelectedTab()) << message_;
106 EXPECT_TRUE(ExecutePasteInSelectedTab()) << message_; 106 EXPECT_TRUE(ExecutePasteInSelectedTab()) << message_;
107 EXPECT_TRUE(ExecuteCommandInIframeInSelectedTab("copy")) << message_; 107 EXPECT_TRUE(ExecuteCommandInIframeInSelectedTab("copy")) << message_;
108 EXPECT_TRUE(ExecuteCommandInIframeInSelectedTab("paste")) << message_; 108 EXPECT_TRUE(ExecuteCommandInIframeInSelectedTab("paste")) << message_;
109 } 109 }
110 110
111 IN_PROC_BROWSER_TEST_F(ClipboardApiTest, HostedAppNoPermission) { 111 IN_PROC_BROWSER_TEST_F(ClipboardApiTest, HostedAppNoPermission) {
112 ASSERT_TRUE(LoadHostedApp("hosted_app_no_permission", "main.html")) 112 ASSERT_TRUE(LoadHostedApp("hosted_app_no_permission", "main.html"))
113 << message_; 113 << message_;
114 114
115 EXPECT_FALSE(ExecuteCopyInSelectedTab()) << message_; 115 // TODO(dcheng): The test coverage here is incomplete. The content test utils
116 // for executing script force a user gesture, so it's impossible to test
117 // the no user gesture case without a lot of code duplication.
118 EXPECT_TRUE(ExecuteCopyInSelectedTab()) << message_;
116 EXPECT_FALSE(ExecutePasteInSelectedTab()) << message_; 119 EXPECT_FALSE(ExecutePasteInSelectedTab()) << message_;
117 EXPECT_FALSE(ExecuteCommandInIframeInSelectedTab("copy")) << message_; 120 EXPECT_TRUE(ExecuteCommandInIframeInSelectedTab("copy")) << message_;
118 EXPECT_FALSE(ExecuteCommandInIframeInSelectedTab("paste")) << message_; 121 EXPECT_FALSE(ExecuteCommandInIframeInSelectedTab("paste")) << message_;
119 } 122 }
120 123
OLDNEW
« no previous file with comments | « chrome/browser/extensions/content_capabilities_browsertest.cc ('k') | chrome/renderer/content_settings_observer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698