Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Unified Diff: chrome/browser/extensions/extension_dom_clipboard_apitest.cc

Issue 913253002: Fix clipboard permission callbacks to account for default values. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix another test Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_dom_clipboard_apitest.cc
diff --git a/chrome/browser/extensions/extension_dom_clipboard_apitest.cc b/chrome/browser/extensions/extension_dom_clipboard_apitest.cc
index ff8a1f4b0efb28b3822c1c9f3b7b074ca10f0abb..f48ce692b6536f176f5e584fd2ae707622b973dd 100644
--- a/chrome/browser/extensions/extension_dom_clipboard_apitest.cc
+++ b/chrome/browser/extensions/extension_dom_clipboard_apitest.cc
@@ -112,9 +112,12 @@ IN_PROC_BROWSER_TEST_F(ClipboardApiTest, HostedAppNoPermission) {
ASSERT_TRUE(LoadHostedApp("hosted_app_no_permission", "main.html"))
<< message_;
- EXPECT_FALSE(ExecuteCopyInSelectedTab()) << message_;
+ // TODO(dcheng): The test coverage here is incomplete. The content test utils
+ // for executing script force a user gesture, so it's impossible to test
+ // the no user gesture case without a lot of code duplication.
+ EXPECT_TRUE(ExecuteCopyInSelectedTab()) << message_;
EXPECT_FALSE(ExecutePasteInSelectedTab()) << message_;
- EXPECT_FALSE(ExecuteCommandInIframeInSelectedTab("copy")) << message_;
+ EXPECT_TRUE(ExecuteCommandInIframeInSelectedTab("copy")) << message_;
EXPECT_FALSE(ExecuteCommandInIframeInSelectedTab("paste")) << message_;
}
« no previous file with comments | « chrome/browser/extensions/content_capabilities_browsertest.cc ('k') | chrome/renderer/content_settings_observer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698