Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 911423002: [NaCl SDK] Set nacl_allow_thin_archives to 0 in prep for build_nexe change. (Closed)

Created:
5 years, 10 months ago by jvoung (off chromium)
Modified:
5 years, 10 months ago
Reviewers:
bradn, Sam Clegg
CC:
chromium-reviews, binji+watch_chromium.org, Sam Clegg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[NaCl SDK] Set nacl_allow_thin_archives to 0 in prep for build_nexe change. We don't want SDK libraries to be thin archives, but chrome-test builds can use thin archives to save space/time. BUG=454640 TBR=bradnelson@chromium.org (lg'ed from @google.com, but owners file only lists @chromium) Committed: https://crrev.com/d3705ffd1e59b6b3da425798f5ad0eddb15e70bf Cr-Commit-Position: refs/heads/master@{#316259}

Patch Set 1 #

Patch Set 2 : fix unittest #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -9 lines) Patch
M native_client_sdk/src/build_tools/build_artifacts.py View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/build_tools/build_sdk.py View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/build_tools/tests/build_artifacts_test.py View 1 7 chunks +16 lines, -7 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
bradn
lgtm
5 years, 10 months ago (2015-02-11 23:54:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/911423002/20001
5 years, 10 months ago (2015-02-12 20:03:39 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/42368)
5 years, 10 months ago (2015-02-12 20:09:44 UTC) #6
jvoung (off chromium)
chromium.org account? =) Or +sbc
5 years, 10 months ago (2015-02-12 20:12:05 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/911423002/20001
5 years, 10 months ago (2015-02-13 19:17:59 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-13 19:23:40 UTC) #11
commit-bot: I haz the power
5 years, 10 months ago (2015-02-13 19:24:19 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d3705ffd1e59b6b3da425798f5ad0eddb15e70bf
Cr-Commit-Position: refs/heads/master@{#316259}

Powered by Google App Engine
This is Rietveld 408576698