native_client_sdk/src/build_tools/build_artifacts.py - Issue 911423002: [NaCl SDK] Set nacl_allow_thin_archives to 0 in prep for build_nexe change.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: native_client_sdk/src/build_tools/build_artifacts.py

Issue 911423002: [NaCl SDK] Set nacl_allow_thin_archives to 0 in prep for build_nexe change. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix unittest Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: native_client_sdk/src/build_tools/build_artifacts.py

diff --git a/native_client_sdk/src/build_tools/build_artifacts.py b/native_client_sdk/src/build_tools/build_artifacts.py

index ad22c33845c35a583b82614fbc80a6c3dabe845a..c300bcc24bcb0996f8fa663280b9012da42b1d2c 100755

--- a/native_client_sdk/src/build_tools/build_artifacts.py

+++ b/native_client_sdk/src/build_tools/build_artifacts.py

@@ -203,7 +203,7 @@ def NinjaBuild(targets, out_dir):

def GypNinjaBuild(arch, gyp_py_script, gyp_file, targets, out_dir):

gyp_env = dict(os.environ)

gyp_env['GYP_GENERATORS'] = 'ninja'

- gyp_defines = []

+ gyp_defines = ['nacl_allow_thin_archives=0']

if options.mac_sdk:

gyp_defines.append('mac_sdk=%s' % options.mac_sdk)

if arch:

« no previous file with comments | « no previous file | native_client_sdk/src/build_tools/build_sdk.py » ('j') | no next file with comments »