native_client_sdk/src/build_tools/build_sdk.py - Issue 911423002: [NaCl SDK] Set nacl_allow_thin_archives to 0 in prep for build_nexe change.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: native_client_sdk/src/build_tools/build_sdk.py

Issue 911423002: [NaCl SDK] Set nacl_allow_thin_archives to 0 in prep for build_nexe change. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix unittest Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « native_client_sdk/src/build_tools/build_artifacts.py ('k') | native_client_sdk/src/build_tools/tests/build_artifacts_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: native_client_sdk/src/build_tools/build_sdk.py

diff --git a/native_client_sdk/src/build_tools/build_sdk.py b/native_client_sdk/src/build_tools/build_sdk.py

index f2c5d60ce9d3e092e9680dbe2df93f3bf6181745..1bc4ebf3c051870456c93288d2ea20bcd3518ed9 100755

--- a/native_client_sdk/src/build_tools/build_sdk.py

+++ b/native_client_sdk/src/build_tools/build_sdk.py

@@ -524,7 +524,7 @@ def GypNinjaBuild_Pnacl(rel_out_dir, target_arch):

def GypNinjaBuild(arch, gyp_py_script, gyp_file, targets, out_dir):

gyp_env = dict(os.environ)

gyp_env['GYP_GENERATORS'] = 'ninja'

- gyp_defines = []

+ gyp_defines = ['nacl_allow_thin_archives=0']

if options.mac_sdk:

gyp_defines.append('mac_sdk=%s' % options.mac_sdk)

if arch is not None: